-
-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] stock_inventory_non_stocked #2019
base: 16.0
Are you sure you want to change the base?
Conversation
LGTM |
I been testing and LGTM! |
LGTM 🤗 |
Very useful addition. LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linuxivan Thanks for this.
Code review.
@jaloxi @JHernandezConinpe @AitorRamosSantos @Aingeru21 To take into account your review, please use the github feature you find in 'Files changed' tab here. |
…ode optimization and some fixes.
@linuxivan I'm wondering if you don't have a problem with Odoo 0 quants garbage collector ( |
@rousseldenis It should not, as it does not affect if the quant is created by a user, in the inventory adjustments the inventory manager is added as user_id of the quants, so there should not be any problems. |
Indeed, great! |
stock_inventory_non_stocked/tests/test_check_inventory_responsible.py
Outdated
Show resolved
Hide resolved
stock_inventory_non_stocked/tests/test_create_non_stocked_prod.py
Outdated
Show resolved
Hide resolved
… on tests, renamed a method from check to assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@rousseldenis reminder |
This module adds a option to a create a 0 quantity quant for products without any stock and any quants in stock inventory groups.
In previous versions inventory adjustment lines were created, but nowadays the stock_inventory module works directly with quants, which means that no matter how many filters you use, if the product does not have a quant it will not appear in the adjustment.
This module creates a quant at 0 to solve this problem.