Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] stock_inventory_non_stocked #2019

Open
wants to merge 9 commits into
base: 16.0
Choose a base branch
from
Open

Conversation

linuxivan
Copy link

This module adds a option to a create a 0 quantity quant for products without any stock and any quants in stock inventory groups.

In previous versions inventory adjustment lines were created, but nowadays the stock_inventory module works directly with quants, which means that no matter how many filters you use, if the product does not have a quant it will not appear in the adjustment.
This module creates a quant at 0 to solve this problem.

@jaloxi
Copy link

jaloxi commented May 6, 2024

LGTM

@JHernandezConinpe
Copy link
Contributor

I been testing and LGTM!

@AitorRamosSantos
Copy link

AitorRamosSantos commented May 6, 2024

LGTM 🤗

@Aingeru21
Copy link

Very useful addition. LGTM

@rousseldenis rousseldenis added this to the 16.0 milestone May 7, 2024
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linuxivan Thanks for this.

Code review.

stock_inventory_non_stocked/models/product_template.py Outdated Show resolved Hide resolved
stock_inventory_non_stocked/models/product_template.py Outdated Show resolved Hide resolved
stock_inventory_non_stocked/models/product_template.py Outdated Show resolved Hide resolved
stock_inventory_non_stocked/models/stock_inventory.py Outdated Show resolved Hide resolved
stock_inventory_non_stocked/models/stock_inventory.py Outdated Show resolved Hide resolved
stock_inventory_non_stocked/models/stock_inventory.py Outdated Show resolved Hide resolved
@rousseldenis
Copy link
Contributor

@jaloxi @JHernandezConinpe @AitorRamosSantos @Aingeru21 To take into account your review, please use the github feature you find in 'Files changed' tab here.

image

@rousseldenis
Copy link
Contributor

rousseldenis commented Sep 6, 2024

@linuxivan I'm wondering if you don't have a problem with Odoo 0 quants garbage collector (_quant_tasks()) that is called at quants view opening from product form ?

@linuxivan
Copy link
Author

@linuxivan I'm wondering if you don't have a problem with Odoo 0 quants garbage collector (_quant_tasks()) that is called at quants view opening from product form ?

@rousseldenis It should not, as it does not affect if the quant is created by a user, in the inventory adjustments the inventory manager is added as user_id of the quants, so there should not be any problems.

@rousseldenis
Copy link
Contributor

@linuxivan I'm wondering if you don't have a problem with Odoo 0 quants garbage collector (_quant_tasks()) that is called at quants view opening from product form ?

@rousseldenis It should not, as it does not affect if the quant is created by a user, in the inventory adjustments the inventory manager is added as user_id of the quants, so there should not be any problems.

Indeed, great!

Copy link

@TelmoSuarez TelmoSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@linuxivan
Copy link
Author

@rousseldenis reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants