Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][ADD] stock_lot_note: Add notes field to Lots #786

Merged
merged 1 commit into from
Oct 23, 2020
Merged

[10.0][ADD] stock_lot_note: Add notes field to Lots #786

merged 1 commit into from
Oct 23, 2020

Conversation

rousseldenis
Copy link
Contributor

No description provided.

@rousseldenis rousseldenis added this to the 10.0 milestone Dec 10, 2019
bodedra
bodedra reviewed Dec 10, 2019
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor one.

stock_lot_note/__manifest__.py Outdated
'category': 'Warehouse',
'maintainers': ['rousseldenis'],
'author': 'ACSONE SA/NV,Odoo Community Association (OCA)',
'website': 'https://acsone.eu',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'website': 'https://acsone.eu',
'website': 'https://github.com/OCA/stock-logistics-warehouse',

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bodedra Done

bodedra
bodedra approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional reviewed. 👍

stock_lot_note/readme/USAGE.rst Outdated Show resolved Hide resolved
ps-tubtim
ps-tubtim approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@ps-tubtim ps-tubtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Member

dreispt commented Oct 22, 2020

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-786-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e7f0a0f into OCA:10.0 Oct 23, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 34b0174. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps-tubtim ps-tubtim ps-tubtim approved these changes

@bodedra bodedra bodedra approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rousseldenis @OCA-git-bot @dreispt @bodedra @ps-tubtim