Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][FIX] stock_owner_restriction: Wrong qty available computation for owner and product at the same time #1728

Conversation

sergio-teruel
Copy link
Contributor

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair

@rousseldenis
Copy link
Contributor

@sergio-teruel Should be great to add a little test for that (and maybe in README too?)

@pedrobaeza pedrobaeza added this to the 15.0 milestone Sep 23, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergio-teruel are you adding the tests?

stock_owner_restriction/models/product.py Outdated Show resolved Hide resolved
@sergio-teruel
Copy link
Contributor Author

Pending to add tests..

@sergio-teruel sergio-teruel force-pushed the 15.0-FIX-stock_owner_restriction-compute-quantities branch from ba50afd to 768f409 Compare September 23, 2024 12:52
@sergio-teruel
Copy link
Contributor Author

Changes done!!

@rousseldenis I do not need a new test only remove the invalidate_cache in this test (https://github.com/OCA/stock-logistics-workflow/pull/1728/files#diff-5a28e7658e415aaa39f5bcfcbf1ed6888fd8acb55164767f5a554f9285a21b5aR69)

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1728-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0b3b002 into OCA:15.0 Sep 23, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a87e986. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-FIX-stock_owner_restriction-compute-quantities branch September 23, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants