-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.0] add pylint-odoo pre-commit hook #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbidoul Thank you. that looks great.Why do you try to test with odoo 13?
2f7c7a0
to
5975be2
Compare
For beta pylint message my current idea is this:
|
85fcfb7
to
98d854a
Compare
5ad87e0
to
14126f5
Compare
Let's wait until the config is stabilized, then don't forget to squash. It's important to have all that in one commit. |
@sbidoul Yes, I'm waiting. My changes are to fix the tests... |
after_success: true | ||
before_install: true | ||
after_success: | ||
before_install: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmignon FYI. This should clarify that after_success and before_install are overrides of the the global default, and not a boolean flag (it was actually running the true command).
a9b0c0f
to
ec16228
Compare
/ocabot merge |
Sorry @lmignon you are not allowed to merge. To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons. If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the |
@sbidoul can you merge this? 🙏 |
Yes of course. BTW, Only @sebastienbeau is part of this PSC. We should invite others. /ocabot merge |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 54fb3f1. Thanks a lot for contributing to OCA. ❤️ |
Add the default pylint config in
.pylintrc
.The benefit of having it in the repo is that IDE can use it without any manual configuration.
still to be investigated