[14.0][FIX] Warning triggered by the onchange

[chmuche]

Hello,
In Odoov14 a warning is display when an @api.onchange return the key domain in the dictionary.

This fix change the domain directly in the view instead of an onchange function

[chmuche]

Potential Conflict with This PR

[fshah-initos]

Looks good to me
Functional test and code review.

[dreispt]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-443-by-dreispt-bump-patch, awaiting test results.

[OCA-git-bot]

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-443-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[dsolanki-initos]

@chmuche can you fix the Travis issue.

[dsolanki-initos]

@chmuche can you fix the Travis issue.

[dsolanki-initos]

@chmuche can you fix the Travis issue.

[dsolanki-initos]

@chmuche can you fix the Travis issue.

[dsolanki-initos]

@chmuche can you fix the Travis issue ASAP.

[dsolanki-initos]

@chmuche it would be nice if you fix the Travis issue.

[dsolanki-initos]

Could you resolve the Travis issue?

[bosd]

@alexey-pelykh Are you a maintainer of this module? Can this be merged?

[alexey-pelykh]

/ocabot merge patch

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-443-by-alexey-pelykh-bump-patch, awaiting test results.

[OCA-git-bot]

@alexey-pelykh your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-443-by-alexey-pelykh-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[alexey-pelykh]

@bosd can't do until Travis is green

[bosd]

How can travis get to green?

[dreispt]

You need to read the TravisCI buld log te see the reason why it is failing.
It seems that tests are failing: https://app.travis-ci.com/github/OCA/timesheet/jobs/562004546#L1967

[bosd]

Seems it is failing due to hr timesheet policy

File "/home/travis/build/OCA/timesheet/setup/hr_timesheet_sheet_policy_project_manager/odoo/addons/hr_timesheet_sheet_policy_project_manager/tests/test_hr_timesheet_sheet_policy_project_manager.py", line 179, in test_project_manager_review_policy

1970 sheet._onchange_project_id()

1971 File "/home/travis/build/OCA/timesheet/setup/hr_timesheet_sheet_policy_project_manager/odoo/addons/hr_timesheet_sheet_policy_project_manager/models/hr_timesheet_sheet.py", line 84, in _onchange_project_id

1972 return self.onchange_add_project_id()

1973AttributeError: 'hr_timesheet.sheet' object has no attribute 'onchange_add_project_id'

1974 

Only the french language file is changed. Could you also change the pot file?

[dreispt]

@bosd This PR changes Python and XML files, and in particular it removes the method the tests complain is missing: https://github.com/OCA/timesheet/pull/443/files#diff-1f9ae96af55f7b3bc30cba579b3c9a29cefbc335f03e423a75fe2f4c0404d2aeL444

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[ikapasi-initos]

@chmuche can you fix the Travis issue.

[ikapasi-initos]

@chmuche it would be nice if you fix the Travis issue.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[chmuche]

This pull request is only here to remove a warning, and I don't use this module anymore.