Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][mig] hr_timesheet_time_type: Migration to 16.0 #582

Closed

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

@dsolanki-initos dsolanki-initos mentioned this pull request Apr 13, 2023
16 tasks
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review LGTM.

Maybe also add the Time Type field to this form?
image

@CRogos
Copy link
Contributor

CRogos commented Jun 15, 2023

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
@pedrobaeza: I am struggling myself with this step, but would squashing the yellow marked commits with the lines above correct? Or are there lines marked which shouldn't be squashed?
image

@pedrobaeza
Copy link
Member

Yes, all except 4 will be correct. The point 4 would be to squash the next ones into it.

@flotho
Copy link
Member

flotho commented Jun 27, 2023

Hi @dsolanki-initos
thanks for the job.
Did you planned to work on this one and deal with previous comments?

@HaraldPanten
Copy link

@pedrobaeza Could you close this one? We superseded in --> #608

THX!

@pedrobaeza
Copy link
Member

pedrobaeza commented Aug 29, 2023

Which is the problem with this PR?

@HaraldPanten
Copy link

HaraldPanten commented Aug 29, 2023

It has not been continued since June

@pedrobaeza
Copy link
Member

Superseded by #608

@pedrobaeza pedrobaeza closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.