[16.0][mig] hr_timesheet_task_domain #586
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (1 of 1 strings) Translation: timesheet-12.0/timesheet-12.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-12-0/timesheet-12-0-hr_timesheet_task_domain/de/
It's `project.task.type`, not `project.stage`.
Currently translated at 75.0% (3 of 4 strings) Translation: timesheet-14.0/timesheet-14.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-14-0/timesheet-14-0-hr_timesheet_task_domain/fr/
Currently translated at 100.0% (4 of 4 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_domain/fr/
Currently translated at 100.0% (1 of 1 strings) Translation: timesheet-15.0/timesheet-15.0-hr_timesheet_task_domain Translate-URL: https://translation.odoo-community.org/projects/timesheet-15-0/timesheet-15-0-hr_timesheet_task_domain/it/
|
/ocabot migration hr_timesheet_task_domain |
|
You should review the migrations guidelines and Squash administrative commits with the previous commit for reducing commit noise for example : Translated using Weblate or README.rst |
| from odoo.tests import common | ||
|
|
||
|
|
||
| class TestHrTimesheetTaskDomain(common.TransactionCase): |
There was a problem hiding this comment.
Suggested change
| class TestHrTimesheetTaskDomain(common.TransactionCase): | |
| class TestHrTimesheetTaskDomain(TransactionCase): |
| # Copyright 2019 Brainbean Apps (https://brainbeanapps.com) | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html). | ||
|
|
||
| from odoo.tests import common |
There was a problem hiding this comment.
Suggested change
| from odoo.tests import common | |
| from odoo.tests import TransactionCase |
|
ping @heliaktiv |
|
Hi, |
DorianMAG
approved these changes
Jun 26, 2023
|
This PR has the |
pedrobaeza
requested changes
Jun 26, 2023
There was a problem hiding this comment.
You should change domains to something not returned in onchange, as that's deprecated. @Yadier-Tecnativa take care of this migration.
| @@ -19,7 +19,6 @@ def _onchange_project_id(self): | |||
| if self.project_id: # Show only opened tasks | |||
| task_domain = [ | |||
| ("project_id", "=", self.project_id.id), | |||
| ("stage_id.is_closed", "=", False), | |||
|
Supersede by #593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.