-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port framework_agreement_requisition #10
port framework_agreement_requisition #10
Conversation
lepistone
commented
Oct 21, 2014
- make tests pass in v8
- functional test
minimal work to make the module installable and make the tests pass
tests are red because of OCA/purchase-workflow#32 |
This is because framwork_agreement_requisition depends on framework_agreement which is in purchase_workflow
because framework_agreement needs web_context_tunnel
0fb59ee
to
4d6c22f
Compare
👍 |
Hi @gurneyalex @jgrandguillaume I marked as WIP because that probably needs some functional testing. Please restore "needs review" and update the checklist when it's OK for you. Thanks! |
I actually have some work to do here. Let's leave it WIP for now. |
This is because the agreement is generated without prices. The wizard tells the user about that.
I did some manual testing. The agreement is generated with price zero. Being that a missing feature, I added doc and a popup to tell the user that prices have to be filled up manually. |
I am adding a few minor things. What is there should not change significantly. |
Minor change done. |
return wf_service.trg_validate(uid, 'purchase.requisition', | ||
agr_id, 'select_agreement', cr) | ||
return workflow.trg_validate(uid, 'purchase.requisition', | ||
agr_id, 'select_agreement', cr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use
class BaseModel(object):
def signal_workflow(self, cr, uid, ids, signal, context=None):
It also works for multiple ids.
it misses the pot update for confirm_generate_agreement wizard |
@yvaucher done, thanks! |
12edab9
to
894ff81
Compare
👍 @lepistone thanks |
Applied @yvaucher's remark to another file, too. |
👍 merging! |
…ition port framework_agreement_requisition