Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port framework_agreement_requisition #10

Merged
merged 16 commits into from
Oct 31, 2014

Conversation

lepistone
Copy link
Member

  • make tests pass in v8
  • functional test

minimal work to make the module installable and make the tests pass
@lepistone
Copy link
Member Author

tests are red because of OCA/purchase-workflow#32

This is because framwork_agreement_requisition depends on
framework_agreement which is in purchase_workflow
because framework_agreement needs web_context_tunnel
@lepistone lepistone force-pushed the port_framework_agreement_requisition branch from 0fb59ee to 4d6c22f Compare October 21, 2014 15:36
@yvaucher
Copy link
Member

👍

@lepistone
Copy link
Member Author

Hi @gurneyalex @jgrandguillaume I marked as WIP because that probably needs some functional testing. Please restore "needs review" and update the checklist when it's OK for you.

Thanks!

@lepistone lepistone self-assigned this Oct 24, 2014
@lepistone
Copy link
Member Author

I actually have some work to do here. Let's leave it WIP for now.

@lepistone
Copy link
Member Author

I did some manual testing. The agreement is generated with price zero. Being that a missing feature, I added doc and a popup to tell the user that prices have to be filled up manually.

@lepistone
Copy link
Member Author

I am adding a few minor things. What is there should not change significantly.

@lepistone
Copy link
Member Author

Minor change done.

return wf_service.trg_validate(uid, 'purchase.requisition',
agr_id, 'select_agreement', cr)
return workflow.trg_validate(uid, 'purchase.requisition',
agr_id, 'select_agreement', cr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use

class BaseModel(object):
    def signal_workflow(self, cr, uid, ids, signal, context=None):

It also works for multiple ids.

@yvaucher
Copy link
Member

it misses the pot update for confirm_generate_agreement wizard

@lepistone
Copy link
Member Author

@yvaucher done, thanks!

@lepistone lepistone force-pushed the port_framework_agreement_requisition branch from 12edab9 to 894ff81 Compare October 31, 2014 08:48
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 894ff81 on lepistone:port_framework_agreement_requisition into 350f5f4 on OCA:8.0.

@yvaucher
Copy link
Member

👍 @lepistone thanks

@lepistone
Copy link
Member Author

Applied @yvaucher's remark to another file, too.

@gurneyalex
Copy link
Member

👍 merging!

gurneyalex added a commit that referenced this pull request Oct 31, 2014
…ition

port framework_agreement_requisition
@gurneyalex gurneyalex merged commit ee60be7 into OCA:8.0 Oct 31, 2014
@lepistone lepistone deleted the port_framework_agreement_requisition branch October 31, 2014 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants