-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue in cost estimate creation #25
Merged
gurneyalex
merged 5 commits into
OCA:8.0
from
gurneyalex:8.0-fill-cost-estimate-sourced-by
Nov 13, 2014
Merged
fix issue in cost estimate creation #25
gurneyalex
merged 5 commits into
OCA:8.0
from
gurneyalex:8.0-fill-cost-estimate-sourced-by
Nov 13, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
populate the sourced_by field of the SO line with the PO line doing the sourcing
👍 |
1 similar comment
👍 |
for line in cost_estimate.order_line: | ||
po_line = line.sourced_by | ||
assert(po_line, 'missing sourced by') | ||
print po_line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You certainly want to remove that print
gurneyalex
added a commit
that referenced
this pull request
Nov 13, 2014
fix issue in cost estimate creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
populate the sourced_by field of the SO line with the PO line doing the
sourcing