Fix default get of wizard 'Create Agreement Purchase Order' #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
👍 |
| if context.get('active_model') == 'logistic.requisition.source': | ||
| source_ids = context['active_ids'] | ||
| else: | ||
| line_ids = context['active_ids'] |
There was a problem hiding this comment.
what about an assert model==LRL here?
|
@yvaucher 👍 with a tiny remark. Ping me for a merge. |
yvaucher
force-pushed
the
8.0-fix-fa-create-po-default_get
branch
from
dccef23
to
49b6b19
Compare
|
@lepistone I fixed your remark plus did some refactoring. |
|
Thanks, I'm waiting for the build. |
Wizard failed sometimes on startup when called from Logistics Requisition Line This was due to a browse of LR Source using ids of LR Line from active_ids
yvaucher
force-pushed
the
8.0-fix-fa-create-po-default_get
branch
from
49b6b19
to
d3451c8
Compare
yvaucher
force-pushed
the
8.0-fix-fa-create-po-default_get
branch
from
ea798ee
to
4577e6f
Compare
nbessi
added a commit
that referenced
this pull request
Dec 3, 2014
Fix default get of wizard 'Create Agreement Purchase Order'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wizard failed sometimes on startup when called from Logistics Requisition Line
This was due to a browse of LR Source using ids of LR Line from
active_ids