Favicon feature

[dreispt]

It would be nice to be have a feature allowing to set the favicon for an Odoo instance or, if possible, depending on the active Company.

Can experts comment if this is feasible? Given some guidelines I could try a PR.

[hbrunn]

This should amount to a module that puts <link rel="shortcut icon" ... in the template website.layout. This could read the current (current as in the website's) company for the icon itself. But without multi website, you'll be stuck with the company your website isl inked to.

[hbrunn]

PS: I think this is an issue for https://github.com/OCA/website

[dreispt]

My personal "pain point" is that my browser as tabs opened in multiple Odoo environments, and a different favicon per instance (or instance/company) would be very helpful.They may not have website enable, so this would be best as a web feature.

[nhomar]

@hbrunn We did ii, at the end we will need 2 modules website_favicon and web_favicon let me port what we did for www.vauxoo.com which is already working (wired in our theme but I can extract it).

It is fairly simple.

[hbrunn]

ah, then you'll need to change it in two places anyways, one web_favicon and website_favicon that depends on this

[hbrunn]

@nhomar I wrote my stuff before I saw yours, exactly that

[nhomar]

jejejeje yes....

[dreispt]

So, I get to choose then... 😉

[lasley]

I just saw this new module, which fills a gap that currently had to be custom configured. I'll go ahead and upgrade this to v9, but I was wondering if the community had any interest in retina friendly favicons?

In order to accomplish this, we would just need a few additional image fields that provide the proper scaling - similar to products with image_small, _medium, etc.

Example of retina favicons:

<!-- For third-generation iPad with high-resolution Retina display: -->
<link rel="apple-touch-icon-precomposed" sizes="144x144" href="apple-touch-icon-144x144-precomposed.png">

<!-- For iPhone with high-resolution Retina display: -->

<link rel="apple-touch-icon-precomposed" sizes="114x114" href="apple-touch-icon-114x114-precomposed.png">

<!-- For first- and second-generation iPad: -->

<link rel="apple-touch-icon-precomposed" sizes="72x72" href="apple-touch-icon-72x72-precomposed.png">

<!-- For non-Retina iPhone, iPod Touch, and Android 2.1+ devices: -->

<link rel="apple-touch-icon-precomposed" href="apple-touch- icon-precomposed.png">

If this is something the community is interested in, I will add during the 9.0 conversion + back-port for this 8.0

[hbrunn]

that's what @pedrobaeza would have liked to have had in #252, but it didn't work out. I think your code will be welcome, even though I personally couldn't care less. But you should implement it in a way that the fancy stuff isn't mandatory.

This issue is done btw, so I'll close it. Forgot that on merge time.

[pedrobaeza]

Hi, @lasley, I have already migrated the module to v9. Please check #344. About retina display icons, please check the Known issues section, where I took into account that. In /static/src/img I have put image samples and HTML basic configuration also for all the possibilities.

[lasley]

Copy, thanks for the insight @hbrunn

Hooray I love it when work I am planning is already done! I'll check into your PR right now, thanks @pedrobaeza

[dreispt]

@lasley that's what it's like to work in community 😉