11.0 mig web listview invert selection #1004
Conversation
* [10.0][ADD] Module web_listview_invert_selection * [FIX] Multiple code reviews * [FIX] Changed single-quotes to double-quotes for improving codacy tests;
There was a problem hiding this comment.
Hi,
I tested this module and it works perfectly. My only concern is for the look of the "Invert selection" button, which I find a bit out of place with the rest of a listview layout. Do you think is it possible to give to the button a look which is more flat so that it can better merge with the rest of the page?
Thank you
|
@espo-tony Agree with you. 👍 |
| @@ -0,0 +1,64 @@ | |||
| .. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | |||
There was a problem hiding this comment.
Not important but it would be nice if you use the new partitioned readme.
| 'aria-label': _t('Invert Selection'), 'title': _t('Invert Selection')}); | ||
| return $('<' + tag + '>') | ||
| .addClass('o_invert_selection') | ||
| .append($icon); |
There was a problem hiding this comment.
Also not blocking but I think using $.wrap() here is a bit cleaner.
| @@ -0,0 +1,5 @@ | |||
| .o_list_view { | |||
| .o_invert_selection { | |||
| padding-left: 2px; | |||
There was a problem hiding this comment.
Can you remove the padding? I think it looks better without it.
|
@MeetKD Are you planning to finish this? |
No description provided.