[11.0] [MIG] web_tree_image #1006

nikul-serpentcs · 2018-07-31T07:34:29Z

Display images and icons in tree view

This module defines a tree image widget, to be used with either binary fields or (function) fields of type character. Use widget='image' in your view definition. Optionally, set a height attribute. Default height is 16px.

…t on arbitrary media subtype

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

set resize="<width>,<height>" in the field tag definition to make the server return a resized version of the image. Useful for saving bandwidth when dealing with large images and to have uniform image sizes (aspect ratio is mantained by filling emtpy areas with transparent background)

JayVora-SerpentCS · 2018-07-31T07:50:09Z

web_tree_image/README.rst

+* Stefan Rijnhart
+* Leonardo Donelli <donelli@webmonks.it>
+* Jay Vora <jay.vora@serpentcs.com>
+* Meet Dholakia <m.dholakia.serpentcs@gmail.com>


Remove Jay and Meet names ; Replace by Serpent Consulting Services Pvt. Ltd. support@serpentcs.com

Well, here it's supposed to have real persons. Your company is in the author list.

Alright, @nikul-serpentcs Add yours, dont remove any.

nikul-serpentcs · 2018-07-31T11:08:37Z

Before, install web_tree_image module tree view look like

and then after installed

Tardo · 2018-08-02T09:04:38Z

Perhaps can be interesting show the image, in something like a tooltip, with real size when mouse is over the image.

nikul-serpentcs · 2018-08-02T11:33:11Z

Perhaps can be interesting show the image, in something like a tooltip, with real size when mouse is over the image.

@OCA/web-maintainers Could you please confirm this, So I will work on it.

CC @Tardo

pedrobaeza · 2018-08-02T11:39:26Z

Yeah, that option is very interesting, but still limited the tooltip to a maximum size (based on a percentage of screen size for example), for avoiding overflowing the view when presenting the tooltip on very large images.

elicoidal · 2018-08-06T14:21:49Z

web_tree_image/README.rst

@@ -0,0 +1,55 @@
+.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg


missing the target

elicoidal · 2018-08-06T14:23:14Z

web_tree_image/README.rst

+* Meet Dholakia <m.dholakia.serpentcs@gmail.com>
+* Nikul Chaudhary <nikul.chaudhary.serpentcs@gmail.com>
+
+Maintainer


Standard footers or better the new fragmented README

@elicoidal Improved Standard footer.

elicoidal · 2018-08-06T14:23:46Z

web_tree_image/__manifest__.py

+
+{
+    'name': 'Show images in tree views',
+    'version': '11.0.1.1.0',


if first version then 11.0.1.0.0

tarteo

I don't think it works without Javascript. Did you forget to commit it?

tarteo · 2018-08-08T13:38:23Z

web_tree_image/README.rst

+
+This module defines a tree image widget, to be used with either binary fields
+or (function) fields of type character. Use ``widget='image'`` in your view
+definition. Optionally, set a ``height`` attribute. Default height is 16px.


I think the default height is 30px (in the less file)

tarteo · 2018-08-08T13:40:46Z

web_tree_image/README.rst

+
+Set the attribute ``widget=image`` in a ``field`` tag in a tree view.
+You can also set ``height=<height>`` to set the height the image will have.
+Note that this just sets the CSS ``max-height`` attribute,


Is this still the case without the Javascript?

nikul-serpentcs · 2018-08-09T10:03:49Z

Yes @tarteo, In V11 added a widget for an image but height and width are not proper, so no need to Javascript for a particular widget. The only CSS we have a used and added a width in here

And those things are described in already #1006 (comment).

Thanks.

nikul-serpentcs · 2018-09-04T07:46:57Z

@pedrobaeza @Tardo @JayVora-SerpentCS

Added a tooltip as per #1006 (comment)

Added mouse over event in image section then appeared Tooltip

tarteo · 2018-09-04T11:23:25Z

web_tree_image/static/src/js/tooltip.js

+    events: _.extend({}, ListRenderer.prototype.events, {
+    	'mouseover tbody tr td .o_field_image': '_onHoverRecord_img',
+    }),
+	_onHoverRecord_img: function (event) {


Can you make the indentation straight?

@Tardo Done

tarteo

Thanks. The tooltip is great!

nikul-serpentcs · 2018-09-04T11:51:13Z

@tarteo Thanks to you too 😃

nikul-serpentcs · 2018-09-05T04:31:22Z

@OCA/web-maintainers If Code & functional Review is done then move forward.

nikul-serpentcs · 2018-09-06T07:27:39Z

@pedrobaeza @Tardo Waiting for your replay, If Done then merged.

AaronHForgeFlow

👍 Functional test

Tardo · 2018-09-10T15:00:09Z

Functional OK but for me can be improved if tooltip shows with less delay... and scale image respecting proportions.. perhaps using 'image cropping'...

👍

nikul-serpentcs · 2018-09-11T11:27:08Z

@Tardo In the image, I used responsive classes and I checked in mobile view its work Good. In Code, I tried to reduce the maximum delay problems.

nikul-serpentcs · 2018-09-19T04:29:25Z

@pedrobaeza @OCA/web-maintainers Waiting for your replay, If Done then move forward.

pedrobaeza · 2018-09-19T07:06:44Z

It lacks this comment: "Functional OK but for me can be improved if tooltip shows with less delay.."

nikul-serpentcs · 2018-09-19T07:55:19Z

@pedrobaeza I added a delay parameter with less delay issue, Could you please review it?

CC @Tardo

JayVora-SerpentCS · 2018-09-20T12:41:20Z

Thanks @yvaucher

JDSalcedo · 2018-12-17T20:28:03Z

Hi @nikul-serpentcs thanks for your awesome work, I got a questions: if the property height=<height> is not longer available, why keep its usage in README file? or this behavior is in development stage?

nikul-serpentcs · 2018-12-18T07:58:25Z

Hi @nikul-serpentcs thanks for your awesome work, I got a questions: if the property height=<height> is not longer available, why keep its usage in README file? or this behavior is in development stage?

@JDSalcedo I already improved in v12 #1100 . If you have any doubts in v11 then you can Improve code and put change request (PR).

Stefan Rijnhart and others added 18 commits July 31, 2018 12:33

web_tree_widget

1272c21

Handle binary fields. Courtesy of Marcel van der Boom

755982b

manifest

6519c56

Module description

2fc4e64

Move module description to README [FIX] rst line endings [IMP] Commen…

9830fbe

…t on arbitrary media subtype

Widget name 'image' instead of 'tree_image'

c8c2fe7

Capitalization consistency

c3f9612

Add OCA as author of OCA addons

a823efb

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Add missing default oca icons

9660ccf

prefix versions with 8.0

0c500db

Version bump, update README

ad8453f

Make modules uninstallable

95a99f3

Migrated web tree image module to v9

0a08875

Make modules uninstallable

1662935

Rename manifest files

bf46b42

web_tree_image: Porting to 10.0 (OCA#464)

686de5f

Update web_tree_image.pot

721874e

JayVora-SerpentCS suggested changes Jul 31, 2018

View reviewed changes

JayVora-SerpentCS approved these changes Jul 31, 2018

View reviewed changes

nikul-serpentcs mentioned this pull request Jul 31, 2018

Migration to version 11.0 #739

Closed

68 tasks

nikul-serpentcs force-pushed the 11-mig-web_tree_image branch 2 times, most recently from 3dff926 to 0272bcc Compare July 31, 2018 11:01

elicoidal reviewed Aug 6, 2018

View reviewed changes

nikul-serpentcs force-pushed the 11-mig-web_tree_image branch from 12375e5 to f434669 Compare August 8, 2018 08:30

tarteo requested changes Aug 8, 2018

View reviewed changes

[MIG] web_tree_image v11

0c48ab5

nikul-serpentcs force-pushed the 11-mig-web_tree_image branch from cc64360 to 0c48ab5 Compare September 4, 2018 09:30

tarteo requested changes Sep 4, 2018

View reviewed changes

[FIX] Fixed code

052f739

tarteo approved these changes Sep 4, 2018

View reviewed changes

AaronHForgeFlow approved these changes Sep 6, 2018

View reviewed changes

[FIX] Fixed delay time

86c3142

yvaucher approved these changes Sep 20, 2018

View reviewed changes

yvaucher merged commit a5893f5 into OCA:11.0 Sep 20, 2018

nikul-serpentcs mentioned this pull request Nov 9, 2018

[12.0] [MIG] web_tree_image #1100

Closed

nikul-serpentcs deleted the 11-mig-web_tree_image branch November 4, 2020 12:58

nikul-serpentcs mentioned this pull request Nov 24, 2020

Why restrict width of images? #1742

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0] [MIG] web_tree_image #1006

[11.0] [MIG] web_tree_image #1006

nikul-serpentcs commented Jul 31, 2018

JayVora-SerpentCS Jul 31, 2018

pedrobaeza Jul 31, 2018

JayVora-SerpentCS Jul 31, 2018

nikul-serpentcs commented Jul 31, 2018

Tardo commented Aug 2, 2018

nikul-serpentcs commented Aug 2, 2018 •

edited

Loading

pedrobaeza commented Aug 2, 2018

elicoidal Aug 6, 2018

elicoidal Aug 6, 2018

nikul-serpentcs Sep 4, 2018

elicoidal Aug 6, 2018

tarteo left a comment •

edited

Loading

tarteo Aug 8, 2018

tarteo Aug 8, 2018

nikul-serpentcs commented Aug 9, 2018 •

edited

Loading

nikul-serpentcs commented Sep 4, 2018 •

edited

Loading

tarteo Sep 4, 2018

nikul-serpentcs Sep 4, 2018

tarteo left a comment

nikul-serpentcs commented Sep 4, 2018

nikul-serpentcs commented Sep 5, 2018 •

edited

Loading

nikul-serpentcs commented Sep 6, 2018

AaronHForgeFlow left a comment

Tardo commented Sep 10, 2018

nikul-serpentcs commented Sep 11, 2018 •

edited

Loading

nikul-serpentcs commented Sep 19, 2018

pedrobaeza commented Sep 19, 2018

nikul-serpentcs commented Sep 19, 2018 •

edited

Loading

JayVora-SerpentCS commented Sep 20, 2018

JDSalcedo commented Dec 17, 2018

nikul-serpentcs commented Dec 18, 2018

		@@ -0,0 +1,55 @@
		.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg

[11.0] [MIG] web_tree_image #1006

[11.0] [MIG] web_tree_image #1006

Conversation

nikul-serpentcs commented Jul 31, 2018

Display images and icons in tree view

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikul-serpentcs commented Jul 31, 2018

Tardo commented Aug 2, 2018

nikul-serpentcs commented Aug 2, 2018 • edited Loading

pedrobaeza commented Aug 2, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarteo left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikul-serpentcs commented Aug 9, 2018 • edited Loading

nikul-serpentcs commented Sep 4, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarteo left a comment

Choose a reason for hiding this comment

nikul-serpentcs commented Sep 4, 2018

nikul-serpentcs commented Sep 5, 2018 • edited Loading

nikul-serpentcs commented Sep 6, 2018

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Tardo commented Sep 10, 2018

nikul-serpentcs commented Sep 11, 2018 • edited Loading

nikul-serpentcs commented Sep 19, 2018

pedrobaeza commented Sep 19, 2018

nikul-serpentcs commented Sep 19, 2018 • edited Loading

JayVora-SerpentCS commented Sep 20, 2018

JDSalcedo commented Dec 17, 2018

nikul-serpentcs commented Dec 18, 2018

nikul-serpentcs commented Aug 2, 2018 •

edited

Loading

tarteo left a comment •

edited

Loading

nikul-serpentcs commented Aug 9, 2018 •

edited

Loading

nikul-serpentcs commented Sep 4, 2018 •

edited

Loading

nikul-serpentcs commented Sep 5, 2018 •

edited

Loading

nikul-serpentcs commented Sep 11, 2018 •

edited

Loading

nikul-serpentcs commented Sep 19, 2018 •

edited

Loading