Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] web_notify: improve popup UI #1231

Merged
merged 7 commits into from
Apr 5, 2019
Merged

[12.0] web_notify: improve popup UI #1231

merged 7 commits into from
Apr 5, 2019

Conversation

shepilov-vladislav
Copy link
Contributor

@shepilov-vladislav shepilov-vladislav commented Mar 29, 2019

Added all available bootstrap-like notifications (success/danger/warning/info/default).

Screen Shot 2019-03-31 at 5 37 38 PM

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@simahawk simahawk changed the title [ADD]: all available bootstrap notifications (success/danger/warning/… [12.0] web_notify: improve popup UI Apr 2, 2019
@simahawk simahawk added this to the 12.0 milestone Apr 2, 2019
web_notify/models/res_users.py Outdated Show resolved Hide resolved
web_notify/static/src/js/widgets/notification.js Outdated Show resolved Hide resolved
@shepilov-vladislav
Copy link
Contributor Author

@simahawk Did everything as you requested ;)

@simahawk
Copy link
Contributor

simahawk commented Apr 2, 2019

@shepilov-vladislav thanks! One thins tho: seems demo is not working on runbot, if I hit the buttons nothing happens (beside refreshing the form)

@shepilov-vladislav
Copy link
Contributor Author

@shepilov-vladislav thanks! One thins tho: seems demo is not working on runbot, if I hit the buttons nothing happens (beside refreshing the form)

It's required longpoling. Longpoling works on runbot?

…ssage_received` to `on_message` for prevent collisions.
@shepilov-vladislav
Copy link
Contributor Author

@shepilov-vladislav thanks! One thins tho: seems demo is not working on runbot, if I hit the buttons nothing happens (beside refreshing the form)

@simahawk Can you double-check? I made some edits.

@simahawk
Copy link
Contributor

simahawk commented Apr 5, 2019

@shepilov-vladislav on runbot it does not work but I think you are right about longpolling.
I trust you it works locally because I don't have time to test it.

@simahawk simahawk merged commit 9b905c8 into OCA:12.0 Apr 5, 2019
tschanzt pushed a commit to camptocamp/web that referenced this pull request Jun 19, 2019
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
Laurent-Corron pushed a commit to acsone/web that referenced this pull request Nov 14, 2019
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
kevinkhao pushed a commit to akretion/web that referenced this pull request Nov 5, 2020
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
dzungtran89 pushed a commit to dzungtran89/web that referenced this pull request Feb 16, 2021
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
BankyKmitl pushed a commit to BankyKmitl/web that referenced this pull request Dec 13, 2021
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
em230418 pushed a commit to em230418/web that referenced this pull request Mar 31, 2022
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
em230418 pushed a commit to em230418/web that referenced this pull request Apr 28, 2022
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
aiendry-aktivsoftware pushed a commit to aiendry-aktivsoftware/web that referenced this pull request Aug 10, 2022
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
aiendry-aktivsoftware pushed a commit to aiendry-aktivsoftware/web that referenced this pull request Aug 15, 2022
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
JordiBForgeFlow pushed a commit to ForgeFlow/web that referenced this pull request Sep 15, 2022
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
gh-aswanth pushed a commit to gh-aswanth/OCA-web that referenced this pull request Oct 15, 2022
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
gh-aswanth pushed a commit to gh-aswanth/OCA-web that referenced this pull request Oct 15, 2022
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
chienandalu pushed a commit to Tecnativa/web that referenced this pull request Jan 5, 2023
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
baimont pushed a commit to acsone/web that referenced this pull request Feb 17, 2023
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
baimont pushed a commit to acsone/web that referenced this pull request Apr 11, 2023
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
Nikul-OSI pushed a commit to ursais/web that referenced this pull request Feb 13, 2024
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
Nikul-OSI pushed a commit to ursais/web that referenced this pull request Feb 16, 2024
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
trisdoan pushed a commit to trisdoan/web that referenced this pull request Oct 3, 2024
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
trisdoan pushed a commit to trisdoan/web that referenced this pull request Oct 7, 2024
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
trisdoan pushed a commit to trisdoan/web that referenced this pull request Oct 7, 2024
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
trisdoan pushed a commit to trisdoan/web that referenced this pull request Oct 14, 2024
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants