13.0 mig web disable export group #1417
Conversation
[IMP] Automatically add root and admin to group [FIX] Website in manifest
Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_disable_export_group Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_disable_export_group/zh_CN/
|
|
||
| * David Vidal <david.vidal@tecnativa.com> | ||
|
|
||
| * Ammar Officewala <https://twitter.com/AmmarOfficewala> |
There was a problem hiding this comment.
It must be your email address and not any other link.
|
Please fix the travis. |
| Sidebar.include({ | ||
| _addItems: function (sectionCode, items) { | ||
| var _items = items; | ||
| if (!session.is_superuser && sectionCode === 'other' && items.length && !session.group_export_data) { |
There was a problem hiding this comment.
While the user will not be able to see the element, they will still be able to export using web/export/ and other endpoints. Is this something we accept?
|
|
||
| ListController.include({ | ||
| _updateButtons: function (mode) { | ||
| if (this.$buttons) { |
There was a problem hiding this comment.
Not sure about this total overwrite of the super function, what if we called super and then conditionally hide/show the element? Other people might override here and by not calling super we can break stuff.
|
tested functionally and works fine here. The user wont be able to click on Export anymore, since this option is not there anymore. |
|
Please rebase and fix Travis |
|
Hi @ammarofficewla , |
|
Superseded by #1714 as no answer for contributor and Travis is red. |
No description provided.