Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] web_domain_field #1434

Merged
merged 7 commits into from
Jan 24, 2020
Merged

[13.0][MIG] web_domain_field #1434

merged 7 commits into from
Jan 24, 2020

Conversation

Laurent-Corron
Copy link

from 10.0

@Laurent-Corron Laurent-Corron mentioned this pull request Nov 11, 2019
Closed
41 tasks
@pedrobaeza pedrobaeza added this to the 13.0 milestone Nov 11, 2019
@Laurent-Corron Laurent-Corron force-pushed the 13.0-mig-web_domain_field branch 3 times, most recently from fdede8b to ce64e62 Compare November 11, 2019 20:23
nikul-serpentcs
nikul-serpentcs reviewed Nov 12, 2019
View reviewed changes
Copy link
Member

@nikul-serpentcs nikul-serpentcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netpicking

web_domain_field/__manifest__.py Outdated Show resolved Hide resolved
web_domain_field/__manifest__.py Outdated Show resolved Hide resolved
@legalsylvain legalsylvain mentioned this pull request Dec 19, 2019
Closed
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon
Copy link
Contributor

lmignon commented Jan 24, 2020

This one is ready to be merged @pedrobaeza @yajo

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-1434-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 24, 2020
@OCA-git-bot
Merge PR #1434 into 13.0
df2e48c 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 7a0b1cb into OCA:13.0 Jan 24, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 917b2d9. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 13.0-mig-web_domain_field branch January 27, 2020 08:02
@lmignon
Copy link
Contributor

lmignon commented Jan 27, 2020

Thank you @pedrobaeza !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikul-serpentcs nikul-serpentcs nikul-serpentcs left review comments

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

@benwillig benwillig benwillig approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Laurent-Corron @OCA-git-bot @lmignon @pedrobaeza @ThomasBinsfeld @nikul-serpentcs @benwillig @rousseldenis @oca-travis