Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0] ADD web_widget_model_viewer #1640

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

eLBati
Copy link
Member

@eLBati eLBati commented Jul 16, 2020

<model-viewer> is a web component that makes rendering interactive 3D models - optionally in AR - easy to do, on as many browsers and devices as possible. <model-viewer> strives to give you great defaults for rendering quality and performance.

See source repository and documentation.

The model to load is a GLTF 2.0 file format.

See https://www.khronos.org/gltf/ and GLTF overview:

GLTF overview

Many engine developers have already started transitioning to glTF 2.0 to reap performance, portability and quality benefits, including BabylonJS, three.js, Cesium, Sketchfab, and xeogl and instant3Dhub engines. glTF 2.0 is also seeing industry support by companies such as Adobe, Google, Marmoset, Microsoft, NVIDIA, Oculus, UX3D, and more as well as prominent universities such as, University of Pennsylvania and Sapienza University of Rome.

"example" directory contains the GLB file of a chair, that is rendered in the following way:

Eames_Lounge_Chair

Next step: create website_sale_product_model_viewer

@eLBati eLBati force-pushed the 12.0-web_widget_model_viewer branch from 7873d24 to 9796436 Compare July 16, 2020 18:40
Copy link
Contributor

@robyf70 robyf70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the rest LGTM to me

@eLBati eLBati force-pushed the 12.0-web_widget_model_viewer branch from 9796436 to 287a427 Compare July 17, 2020 07:31
@tarteo tarteo added this to the 12.0 milestone Jul 21, 2020
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

@andreampiovesana andreampiovesana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go

@eLBati
Copy link
Member Author

eLBati commented Jul 31, 2020

@OCA/web-maintainers merge?

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-1640-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a255d9e into OCA:12.0 Jul 31, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 939c300. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants