Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14.0 [mig] web_access_rule_buttons #1752

Merged
merged 3 commits into from
May 5, 2021
Merged

14.0 [mig] web_access_rule_buttons #1752

merged 3 commits into from
May 5, 2021

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

@dsolanki-initos dsolanki-initos mentioned this pull request Dec 3, 2020
Closed
34 tasks
@fshah-initos fshah-initos force-pushed the 14.0-mig-web_access_rule_buttons branch from 61b1c85 to 205fa85 Compare January 4, 2021 07:34
@dsolanki-initos dsolanki-initos force-pushed the 14.0-mig-web_access_rule_buttons branch 2 times, most recently from 1563688 to f3028c3 Compare March 2, 2021 12:28
@dsolanki-initos
Copy link
Contributor Author

@ALL can anyone please review this PR?

@CasVissers-360ERP
Copy link

@dsolanki-initos
Functional test, get an error when creating transient models see:
https://drive.google.com/file/d/1-K_Vum0U1SmIS4610qgUOxsoanF475NB/view

@dsolanki-initos
Copy link
Contributor Author

@dsolanki-initos
Functional test, get an error when creating transient models see:
https://drive.google.com/file/d/1-K_Vum0U1SmIS4610qgUOxsoanF475NB/view

Hi @CasVissers-360ERP
I have checked the same scenario as you have shown the video link it is working fine with Transient models also. Have you changed the access rights for the transient model to test?

@dsolanki-initos dsolanki-initos changed the title 14.0 mig web access rule buttons 14.0 mig web_access_rule_buttons Mar 8, 2021
@dsolanki-initos dsolanki-initos changed the title 14.0 mig web_access_rule_buttons 14.0 [mig] web_access_rule_buttons Mar 8, 2021
@CasVissers-360ERP
Copy link

Try this sale order. Nothing changed on this runbot.

@dsolanki-initos dsolanki-initos force-pushed the 14.0-mig-web_access_rule_buttons branch from f3028c3 to 5522a34 Compare March 8, 2021 10:27
@dsolanki-initos
Copy link
Contributor Author

@CasVissers-360ERP I have resolved the issue can you please review it?

@CasVissers-360ERP
Copy link

@dsolanki-initos
Video:
https://drive.google.com/file/d/1LV1ecvuL_PnbK_Z_WTITSShJg01lTs-F/view

Steps:
0. Install analytic App

  1. Create record rule on analytic account: [('company_id','=',False)]
  2. Set record rule to group Discount on lines
  3. Give demo user full accounting rights and add Discount on lines group
  4. Open analytic account as admin -> No error
  5. Open analytic account as demo -> Record Rule error when just opening
  6. Remove module -> No errors

@dsolanki-initos
Copy link
Contributor Author

Hi @CasVissers-360ERP

I have generated the same scenrio Can you please see the link?
https://www.awesomescreenshot.com/video/3011334?key=1848f60aedfe5b91db213b46aa2bfb93

@CasVissers-360ERP
Copy link

@dsolanki-initos
You didn't apply the security group to the demo user?

@dsolanki-initos
Copy link
Contributor Author

@dsolanki-initos
You didn't apply the security group to the demo user?

I have enabled the group "Discount on Lines" for the Demo user

@dsolanki-initos dsolanki-initos force-pushed the 14.0-mig-web_access_rule_buttons branch from 5522a34 to 6a5dd0a Compare March 31, 2021 12:57
@dsolanki-initos dsolanki-initos force-pushed the 14.0-mig-web_access_rule_buttons branch from 6a5dd0a to 7d879a0 Compare March 31, 2021 13:00
@dsolanki-initos
Copy link
Contributor Author

@CasVissers-360ERP Can you please re-check it?

CasVissers-360ERP
CasVissers-360ERP approved these changes Apr 1, 2021
View reviewed changes
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working now, thnx!

@dsolanki-initos
Copy link
Contributor Author

@janverb can you please review this PR?

@dsolanki-initos
Copy link
Contributor Author

It would be nice if someone can add review here.

fshah-initos
fshah-initos approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@fshah-initos fshah-initos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test and code review.

@dsolanki-initos
Copy link
Contributor Author

@OCA/web-maintainers can you please merge this PR?

@dsolanki-initos
Copy link
Contributor Author

@OCA/web-maintainers it would be great if somone can merge the PR

@simahawk
Copy link
Contributor

simahawk commented May 5, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1752-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8eaba5c into OCA:14.0 May 5, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1298635. Thanks a lot for contributing to OCA. ❤️

@ryanc-me ryanc-me mentioned this pull request Sep 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fshah-initos fshah-initos fshah-initos approved these changes

@CasVissers-360ERP CasVissers-360ERP CasVissers-360ERP approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dsolanki-initos @CasVissers-360ERP @simahawk @OCA-git-bot @fshah-initos @foramaktiv