-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.0][MIG] web_set_single_page_hidden #2072
[13.0][MIG] web_set_single_page_hidden #2072
Conversation
1818ce0
to
29425e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking issues imo
var self = this; | ||
return this._super.apply(this, arguments).then(function() { | ||
if (!_.isUndefined(self.pager)) { | ||
self.pager.set_single_page_hidden(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have this configurable from the field options.
Something like: self.pager.set_single_page_hidden(self.options.single_page_hidden);
Is this possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is possible. but don't you think that it should be handled as new PR and not in Migration PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
var Pager = require("web.Pager"); | ||
|
||
Pager.include({ | ||
set_single_page_hidden: function(value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use camelCase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are done.
This PR has the |
@bizzappdev Can you squash your commits so I can merge, please. Thanks |
a4e5738
to
82ff509
Compare
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at f0dc185. Thanks a lot for contributing to OCA. ❤️ |
No description provided.