Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] web_set_single_page_hidden #2072

Merged
merged 6 commits into from
Dec 10, 2021
Merged

[13.0][MIG] web_set_single_page_hidden #2072

merged 6 commits into from
Dec 10, 2021

Conversation

bizzappdev
Copy link

No description provided.

@bizzappdev bizzappdev mentioned this pull request Nov 9, 2021
Closed
41 tasks
@bizzappdev bizzappdev force-pushed the 13.0-web_set_single_page_hidden-bad-rus branch from 1818ce0 to 29425e5 Compare November 9, 2021 04:56
tarteo
tarteo approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues imo

web_set_single_page_hidden/static/src/js/relational_fields.js Outdated
var self = this;
return this._super.apply(this, arguments).then(function() {
if (!_.isUndefined(self.pager)) {
self.pager.set_single_page_hidden(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have this configurable from the field options.
Something like: self.pager.set_single_page_hidden(self.options.single_page_hidden);
Is this possible?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is possible. but don't you think that it should be handled as new PR and not in Migration PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

web_set_single_page_hidden/static/src/js/pager.js Outdated
var Pager = require("web.Pager");

Pager.include({
set_single_page_hidden: function(value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use camelCase

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are done.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@tarteo
Copy link
Member

tarteo commented Nov 30, 2021 •
edited
Loading

@bizzappdev Can you squash your commits so I can merge, please. Thanks

@bizzappdev bizzappdev force-pushed the 13.0-web_set_single_page_hidden-bad-rus branch from a4e5738 to 82ff509 Compare November 30, 2021 14:20
@dreispt
Copy link
Member

dreispt commented Dec 10, 2021

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-2072-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d65a996 into OCA:13.0 Dec 10, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f0dc185. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarteo tarteo tarteo approved these changes

@PCatinean PCatinean PCatinean approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bizzappdev @OCA-git-bot @tarteo @dreispt @PCatinean @vvrossem @oca-travis @marcelsavegnago