fix pylint issues + Update repo from latest MQT #232
Conversation
|
Can you please update Travis for being in line with latest MQT specification? |
|
Okay I'll try! |
|
Thanks! Let me know if you need help |
| - VERSION="7.0" TESTS="0" LINT_CHECK="0" TRANSIFEX="0" | ||
| - TRANSIFEX_USER='transbot@odoo-community.org' | ||
| - secure: PjP88tPSwimBv4tsgn3UcQAD1heK/wcuSaSfhi2xUt/jSrOaTmWzjaW2gH/eKM1ilxPXwlPGyAIShJ2JJdBiA97hQufOeiqxdkWDctnNVVEDx2Tk0BiG3PPYyhXPgUZ+FNOnjZFF3pNWvzXTQaB0Nvz8plqp93Ov/DEyhrCxHDs= | ||
|
|
There was a problem hiding this comment.
This is actually the sample security key, which password should I use to generate it on this project?
There was a problem hiding this comment.
You can refer to this issue to see all Transifex secret:
|
👍 |
1 similar comment
|
👍 |
|
|
||
| [//]: # (addons) | ||
| This part will be replaced when running the oca-gen-addons-table script from OCA/maintainer-tools. | ||
| [//]: # (end addons) |
There was a problem hiding this comment.
I wonder if this part should be add on 8.0 series only or on every branches, does the gen_addons_table script running on all branches?
There was a problem hiding this comment.
For now, it's intended only for >8.0 branch, but as a placeholder, there's no problem to have it here in case the script is also run here.
petrus-v
changed the title
| 'depends': [ | ||
| 'base', | ||
| 'web', | ||
| ], |
There was a problem hiding this comment.
Good catch! Sorry, my bad, I don't know why...
There was a problem hiding this comment.
@dreispt ,
Ohh yes I know, depends was duplicated! see bellow after description.
|
Hi, I wonder if/how javascript unit-test are launch by travis? I've done a quick test adding a failed test but I can't find logs about: https://travis-ci.org/petrus-v/web/builds/83849923 |
|
Maybe on runbot ? |
|
@petrus-v : your link is broken. |
|
@legalsylvain : here you are: https://travis-ci.org/petrus-v/web/builds/83849923 |
|
👍 As all comments have been honoured, I merge for not blocking other PRs |
fix pylint issues + Update repo from latest MQT
Fix recent pylint complaints got in #231 : https://travis-ci.org/OCA/web/builds/82632959