Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][mig] web_company_color: Migration to 16.0 #2449

Closed
wants to merge 42 commits into from

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

Tardo and others added 30 commits March 14, 2023 11:01
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_company_color/zh_CN/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-12.0/web-12.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_company_color/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-13.0/web-13.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-13.0/web-13.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/it/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-13.0/web-13.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/zh_CN/
Currently translated at 100.0% (9 of 9 strings)

Translation: web-13.0/web-13.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/nl/
We need to disable the company unlinking test, as if not, when tested
in integrated environments, it fails as there are records linked to the
company, like the warehouse when `stock` module is installed.
Currently translated at 100.0% (12 of 12 strings)

Translation: web-14.0/web-14.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_company_color/de/
Currently translated at 8.3% (1 of 12 strings)

Translation: web-14.0/web-14.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_company_color/ca/
BernatPForgeFlow and others added 12 commits March 14, 2023 11:01
If we change something with base.document.layout wizard, this will launch the colors computing even without changing the logo. This procedure will change the value of the colors if they were set by hand.

This change forces the user to press a button to recompute the colors and avoid possible undesired changes.

TT34902
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-15.0/web-15.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_company_color/
Currently translated at 100.0% (10 of 10 strings)

Translation: web-15.0/web-15.0-web_company_color
Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_company_color/de/
@dsolanki-initos dsolanki-initos mentioned this pull request Mar 14, 2023
45 tasks
@hbrunn
Copy link
Member

hbrunn commented Mar 15, 2023

is this a duplicate of #2404?

Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional 👍

Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

def _get_asset_content(
self, bundle, nodeAttrs=None, defer_load=False, lazy_load=False
):
@tools.ormcache(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this?

@pedrobaeza
Copy link
Member

Sorry, #2527 was merged accidentally before seeing this one (although I cancelled the action). Can you please check if there's something missing there and comment back?

@pedrobaeza pedrobaeza closed this Jun 10, 2023
@dsolanki-initos
Copy link
Contributor Author

Hi @pedrobaeza, I've functionality tested the module PR #2527 and found that unaligned button view. For the same I've attached an image, kindly check it.
image

The same is already fixed in my PR.
image

@pedrobaeza
Copy link
Member

Please submit the FIX in a new PR.

@dsolanki-initos
Copy link
Contributor Author

Please submit the FIX in a new PR.

I've created a FIX of the web_company_color #2530, Kindly check it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.