-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][mig] web_company_color: Migration to 16.0 #2449
Conversation
Currently translated at 100.0% (9 of 9 strings) Translation: web-12.0/web-12.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_company_color/zh_CN/
Currently translated at 100.0% (9 of 9 strings) Translation: web-12.0/web-12.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_company_color/hr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/
Currently translated at 100.0% (9 of 9 strings) Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/it/
Currently translated at 100.0% (9 of 9 strings) Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/zh_CN/
Currently translated at 100.0% (9 of 9 strings) Translation: web-13.0/web-13.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_company_color/nl/
We need to disable the company unlinking test, as if not, when tested in integrated environments, it fails as there are records linked to the company, like the warehouse when `stock` module is installed.
Currently translated at 100.0% (12 of 12 strings) Translation: web-14.0/web-14.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_company_color/de/
Currently translated at 8.3% (1 of 12 strings) Translation: web-14.0/web-14.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_company_color/ca/
If we change something with base.document.layout wizard, this will launch the colors computing even without changing the logo. This procedure will change the value of the colors if they were set by hand. This change forces the user to press a button to recompute the colors and avoid possible undesired changes. TT34902
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_company_color/
Currently translated at 100.0% (10 of 10 strings) Translation: web-15.0/web-15.0-web_company_color Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_company_color/de/
is this a duplicate of #2404? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
def _get_asset_content( | ||
self, bundle, nodeAttrs=None, defer_load=False, lazy_load=False | ||
): | ||
@tools.ormcache( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this?
Sorry, #2527 was merged accidentally before seeing this one (although I cancelled the action). Can you please check if there's something missing there and comment back? |
Hi @pedrobaeza, I've functionality tested the module PR #2527 and found that unaligned button view. For the same I've attached an image, kindly check it. |
Please submit the FIX in a new PR. |
I've created a FIX of the web_company_color #2530, Kindly check it. |
No description provided.