Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][mig] web_widget_numeric_step: Migration to 16.0 #2456

Merged
merged 30 commits into from
May 2, 2023
Merged

[16.0][mig] web_widget_numeric_step: Migration to 16.0 #2456

merged 30 commits into from
May 2, 2023

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

quentinDupont and others added 29 commits March 16, 2023 18:06
@quentinDupont @dsolanki-initos
[ADD] Widget Numeric step
a5ca007
@Tardo @dsolanki-initos
[IMP] web_widget_numeric_step: Better CSS and supports mobile layouts
def062a
@Tardo @dsolanki-initos
[FIX] web_widget_numeric_step: Float Precision
3e69323
@sergio-teruel @dsolanki-initos
[FIX] web_widget_numeric_step: Fix _onChange input fields methods dis…
074418c 
…abled by the widget
@Tardo @dsolanki-initos
[IMP] web_widget_numeric_step: Event handler
322bb8c
@Tardo @dsolanki-initos
[FIX] web_widget_numeric_step: Change number parse method
dae7e4e 
Previous this commit the widget only works with 'dots', with
this commit works using odoo parse method that support other separators.
@Tardo @dsolanki-initos
[FIX] web_widget_numeri_step: Change click interval
20c2785 
Previous this commit, the task for auto-step can enter in a
infinite loop. Now only creates a new task if no other task is running.
@claudiagn @dsolanki-initos
Added translation using Weblate (Spanish)
2a32183
@claudiagn @dsolanki-initos
Translated using Weblate (Spanish)
6c09ac1 
Currently translated at 100.0% (3 of 3 strings)

Translation: web-12.0/web-12.0-web_widget_numeric_step
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_numeric_step/es/
@dsolanki-initos
[IMP] web_widget_numeric_step: better visualization in list view cells
76d2392
@Tardo @dsolanki-initos
[FIX] web_widget_numeric_step: Only modify widget parent
92f0e6a
@CarlosRoca13 @dsolanki-initos
[IMP] web_widget_numeric_step: black, isort, prettier
973fd6d
@CarlosRoca13 @dsolanki-initos
[MIG] web_widget_numeric_step: Migration to v13
32a464d
@oca-travis @dsolanki-initos
[UPD] Update web_widget_numeric_step.pot
2dee527
@OCA-git-bot @dsolanki-initos
[UPD] README.rst
4c3f0c5
@alessandro-fiorino @dsolanki-initos
Added translation using Weblate (Italian)
a07c2e7
@alessandro-fiorino @dsolanki-initos
Translated using Weblate (Italian)
cdbbc48 
Currently translated at 100.0% (3 of 3 strings)

Translation: web-13.0/web-13.0-web_widget_numeric_step
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_numeric_step/it/
@Tardo @dsolanki-initos
[IMP] web_widget_numeric_step: Add auto_select option
90bc0c4
@OCA-git-bot @dsolanki-initos
web_widget_numeric_step 13.0.1.1.0
6377d69
@fshah-initos @dsolanki-initos
[IMP] web_widget_numeric_step: isort, black, prettier.
67c3733
@hkapatel-initos @dsolanki-initos
[MIG] Migrate module web_widget_numeric_step to v14.
e45c6ef
@oca-travis @dsolanki-initos
[UPD] Update web_widget_numeric_step.pot
72ea2e6
@OCA-git-bot @dsolanki-initos
[UPD] README.rst
a7be36f
@Corneliuus @dsolanki-initos
Added translation using Weblate (German)
99ed30e
@Corneliuus @dsolanki-initos
Translated using Weblate (German)
d330eb8 
Currently translated at 100.0% (3 of 3 strings)

Translation: web-14.0/web-14.0-web_widget_numeric_step
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_numeric_step/de/
@BankyKmitl @dsolanki-initos
[MIG] web_widget_numeric_step: Migration to 15.0
38b717c
@dsolanki-initos
[UPD] Update web_widget_numeric_step.pot
6625cf8
@OCA-git-bot @dsolanki-initos
[UPD] README.rst
614b781
@dsolanki-initos
[IMP] web_widget_numeric_step: pre-commit stuff
976797c
@dsolanki-initos dsolanki-initos force-pushed the 16.0-mig-web_widget_numeric_step branch from cfcb4d2 to 12f9633 Compare March 16, 2023 13:01
@dsolanki-initos dsolanki-initos mentioned this pull request Mar 16, 2023
Open
45 tasks
@legalsylvain
Copy link
Contributor

CC : @quentinDupont

Tardo
Tardo requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!
I see some issues and another thing that I see that has been lost is being able to hold the subtract or add button to increase or decrease.

.pre-commit-config.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not be here.

web_environment_ribbon/models/web_environment_ribbon_backend.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not be here.

web_environment_ribbon/tests/test_environment_ribbon_data.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should not be here.

web_widget_numeric_step/static/description/add_two_buttons.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, update this image.

web_widget_numeric_step/static/description/step0,25andlimits.gif Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can, update this image.

web_widget_numeric_step/static/description/step10_limit15_placeholder117_with_onchange.gif Outdated Show resolved Hide resolved
web_widget_numeric_step/static/src/xml/numeric_step.xml Outdated Show resolved Hide resolved
@dsolanki-initos dsolanki-initos force-pushed the 16.0-mig-web_widget_numeric_step branch from 12f9633 to 44af572 Compare March 21, 2023 05:30
@dsolanki-initos dsolanki-initos force-pushed the 16.0-mig-web_widget_numeric_step branch from 44af572 to 2b72477 Compare March 21, 2023 05:43
@dsolanki-initos
Copy link
Contributor Author

@Tardo, I've done the changes as per your feedback, Kindly review It.
Thank you

Tardo
Tardo approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! It's a pity that we don't have a layout that fits our needs :/

antoniocanovas
antoniocanovas approved these changes May 2, 2023
View reviewed changes
Copy link

@antoniocanovas antoniocanovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK !!

@pedrobaeza
Copy link
Member

/ocabot migration web_widget_numeric_step
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone May 2, 2023
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2456-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4c32e29 into OCA:16.0 May 2, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f3a513d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniocanovas antoniocanovas antoniocanovas approved these changes

@Tardo Tardo Tardo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.