Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][mig] web_copy_confirm: Migration to 16.0 #2458

Merged
merged 11 commits into from
Mar 9, 2024
Merged

[16.0][mig] web_copy_confirm: Migration to 16.0 #2458

merged 11 commits into from
Mar 9, 2024

Conversation

dsolanki-initos
Copy link
Contributor

No description provided.

@dsolanki-initos dsolanki-initos mentioned this pull request Mar 20, 2023
Open
45 tasks
legalsylvain
legalsylvain approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@legalsylvain legalsylvain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review / no code review. 👍 thanks !

Tardo
Tardo requested changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work!

web_copy_confirm/readme/newsfragments/.gitkeep Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this can be removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed it.

web_copy_confirm/static/src/js/web_copy_confirm.esm.js Outdated
import {_t} from "@web/core/l10n/translation";
import {FormController} from "@web/views/form/form_controller";

patch(FormController.prototype, "user_recent_log/static/src/js/record_save.js", {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the 'patchName'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tardo Changed the patch name, Kindly review it. Thank you

StefanRijnhart and others added 11 commits March 21, 2023 10:15
Tardo
Tardo approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@Tardo Tardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dsolanki-initos
Copy link
Contributor Author

dsolanki-initos commented Mar 29, 2023 •
edited
Loading

Can we merge this PR?

SirAionTech
SirAionTech approved these changes Mar 7, 2024
View reviewed changes
Copy link

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dreispt
Copy link
Member

dreispt commented Mar 9, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2458-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 64243ec into OCA:16.0 Mar 9, 2024
2 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 09848c0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirAionTech SirAionTech SirAionTech approved these changes

@legalsylvain legalsylvain legalsylvain approved these changes

@enriquemartin enriquemartin enriquemartin approved these changes

@Tardo Tardo Tardo approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.