[16.0][MIG] web_ir_actions_act_window_page #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbrunn
force-pushed
the
16.0-web_ir_actions_act_window_page
branch
from
2d9349d
to
f5b8329
Compare
tarteo
approved these changes
Jul 11, 2023
|
/ocabot migration web_ir_actions_act_window_page |
|
Please mention the version numbers in your migration commits. |
StefanRijnhart
requested changes
Jul 21, 2023
ged-odoo
reviewed
Jul 21, 2023
| patch(Pager.prototype, "navigate event listener", { | ||
| setup() { | ||
| this._super.apply(); | ||
| const handleNavigate = (ev) => this._handleNavigate(ev); |
There was a problem hiding this comment.
random unsolicited code review. I hope it's not rude. You can import useBus from "@web/core/utils/hooks". It allow you to register when mounted and it will take care of unregistering when unmounted:
useBus(this.env.bus, "pager:navigate", handleNavigate);There was a problem hiding this comment.
on the contrary, very much appreciated and sorry for the long delay! Took your suggestion in 3a0e116
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
hbrunn
force-pushed
the
16.0-web_ir_actions_act_window_page
branch
from
3a0e116
to
0cf9d4c
Compare
hbrunn
force-pushed
the
16.0-web_ir_actions_act_window_page
branch
from
0cf9d4c
to
06c1460
Compare
StefanRijnhart
approved these changes
Jul 31, 2023
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at ba22257. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addon allows a developer to return the following action types:
{'type': 'ir.actions.act_window.page.next'}or:
{'type': 'ir.actions.act_window.page.prev'}which trigger the form's controller to page into the requested direction on the client
side.
A use case could be the case of a validation flow. As a developer, you set up a tree
view with a domain on records to be validated. The user opens the first record in a form
view and validates the record. The validation method returns the 'next' action type so
that the browser window of the user is presented with the next record in the form view.