Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] web_chatter_position #2569

Merged
merged 6 commits into from
Jul 25, 2023
Merged

[13.0][MIG] web_chatter_position #2569

merged 6 commits into from
Jul 25, 2023

Conversation

SergiCForgeFlow
Copy link

No description provided.

LoisRForgeFlow
LoisRForgeFlow approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review in EE and CE (without web_responsive). Working as expected 👍

JoanSForgeFlow
JoanSForgeFlow approved these changes Jul 21, 2023
View reviewed changes
Copy link

@JoanSForgeFlow JoanSForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JordiMForgeFlow
JordiMForgeFlow approved these changes Jul 21, 2023
View reviewed changes
Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + functional review 👍🏼

@LoisRForgeFlow
Copy link
Contributor

It looks like the field appears twice in the user preferences view: image

That is because the feature is also included in web_responsive, this module extract it to be able to have the feature without web_responsive or with web_enterprise

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member

/ocabot merge nobump
/ocabot migration web_chatter_position

@OCA-git-bot OCA-git-bot added this to the 13.0 milestone Jul 25, 2023
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-2569-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 25, 2023
Closed
41 tasks
@OCA-git-bot OCA-git-bot merged commit cc795df into OCA:13.0 Jul 25, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a5cc63d. Thanks a lot for contributing to OCA. ❤️

@LoisRForgeFlow LoisRForgeFlow deleted the 13.0-mig-web_chatter_position branch July 26, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@JoanSForgeFlow JoanSForgeFlow JoanSForgeFlow approved these changes

@JordiMForgeFlow JordiMForgeFlow JordiMForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
7 participants
@SergiCForgeFlow @LoisRForgeFlow @OCA-git-bot @etobella @JoanSForgeFlow @JordiMForgeFlow @JuMiSanAr