-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] web_m2x_options_manager : Migrate to 16.0 #2587
base: 16.0
Are you sure you want to change the base?
[16.0][MIG] web_m2x_options_manager : Migrate to 16.0 #2587
Conversation
/ocabot migration web_m2x_options_manager |
class IrModelFields(models.Model): | ||
_inherit = "ir.model.fields" | ||
|
||
@api.model |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QuocDuong1306 kindly check this function .it has completely changed in odoo v16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the last function on file ir_model.py
def name_serch.....it has changed in odoo v16
b90854d
to
ed3b9b8
Compare
Thanks for your reviews, I updated |
Can you check if the "Create & Edit Wizard" is working? I don't see any difference when is True and when is False. |
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2587-by-dreispt-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@QuocDuong1306 could you please fix pre-commit issues? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, the module is not achieving its primary goal of properly managing the options for creation and editing/creation. I have made specific configurations in the res.partner and sale.order models to eliminate the options of "Create" and "Edit/Create".
In the attached video, it can be observed that for the sale.order model, I have configured the "Force remove" option for the partner_id and tag_ids fields. These configurations were applied correctly, preventing the possibility of "Create" and "Edit and Create".
However, when dealing with the res.partner model, I used the same "Force remove" configuration for the team_id and user_id fields. Unfortunately, while this configuration works for team_id, it does not effectively transfer to the user_id field, meaning that editing and creation in this field are still allowed.
Odoo.-.Sales.Order.mp4
@QuocDuong1306 After reviewing the previous comment in the PR where the error is located, will changes be added to continue the migration? |
Hi, sorry for the delay, I will update the PR asap |
…ons from interface
- Fix postprocess inherit (removed from v15), and use _postprocess_tag_field for create/edit options: In v14 it worked with inheriting the "postprocess" method because in each recursive call it passed a section of the view, in the way that it went through all the child nodes of the root node, and passed through the fields, and now in v15 the method "_postprocess_view "it just does the while, and we never go through the nodes. - Fix pylint errors: xml-deprecated-tree-attributte, attribute-string-redundant, translation-positional-used
ed3b9b8
to
74f81c0
Compare
74f81c0
to
3e18b4e
Compare
Hello guys, the PR is updated |
Hello @aliciagaarzo , the issue is fixed, could you have a look? Screencast.from.2024-08-06.14-18-37.webm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
This PR takes over: