Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] web_m2x_options_manager : Migrate to 16.0 #2587

Open
wants to merge 10 commits into
base: 16.0
Choose a base branch
from

Conversation

QuocDuong1306
Copy link

@pedrobaeza
Copy link
Member

/ocabot migration web_m2x_options_manager

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 11, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 11, 2023
45 tasks
class IrModelFields(models.Model):
_inherit = "ir.model.fields"

@api.model

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuocDuong1306 kindly check this function .it has completely changed in odoo v16.

Copy link

@Kinyuaeric Kinyuaeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check the last function on file ir_model.py

def name_serch.....it has changed in odoo v16

@QuocDuong1306
Copy link
Author

Thanks for your reviews, I updated

@moitabenfdz
Copy link

Can you check if the "Create & Edit Wizard" is working? I don't see any difference when is True and when is False.

@dreispt
Copy link
Member

dreispt commented Apr 15, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2587-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 15, 2024
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2587-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@danielduqma
Copy link

@QuocDuong1306 could you please fix pre-commit issues? Thanks!

Copy link

@viviana1503 viviana1503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, the module is not achieving its primary goal of properly managing the options for creation and editing/creation. I have made specific configurations in the res.partner and sale.order models to eliminate the options of "Create" and "Edit/Create".
In the attached video, it can be observed that for the sale.order model, I have configured the "Force remove" option for the partner_id and tag_ids fields. These configurations were applied correctly, preventing the possibility of "Create" and "Edit and Create".
However, when dealing with the res.partner model, I used the same "Force remove" configuration for the team_id and user_id fields. Unfortunately, while this configuration works for team_id, it does not effectively transfer to the user_id field, meaning that editing and creation in this field are still allowed.

Odoo.-.Sales.Order.mp4

@aliciagaarzo
Copy link

@QuocDuong1306 After reviewing the previous comment in the PR where the error is located, will changes be added to continue the migration?

@QuocDuong1306
Copy link
Author

Hi, sorry for the delay, I will update the PR asap

Germana and others added 3 commits August 6, 2024 11:08
- Fix postprocess inherit (removed from v15), and use _postprocess_tag_field
for create/edit options: In v14 it worked with inheriting the "postprocess"
method because in each recursive call it passed a section of the view, in the
way that it went through all the child nodes of the root node, and passed through
the fields, and now in v15 the method "_postprocess_view "it just does the while,
and we never go through the nodes.

- Fix pylint errors: xml-deprecated-tree-attributte, attribute-string-redundant,
translation-positional-used
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-mig-web_m2x_options_manager branch from ed3b9b8 to 74f81c0 Compare August 6, 2024 05:27
@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-mig-web_m2x_options_manager branch from 74f81c0 to 3e18b4e Compare August 6, 2024 05:33
@QuocDuong1306
Copy link
Author

Hello guys, the PR is updated

@QuocDuong1306
Copy link
Author

However, when dealing with the res.partner model, I used the same "Force remove" configuration for the team_id and user_id fields. Unfortunately, while this configuration works for team_id, it does not effectively transfer to the user_id field, meaning that editing and creation in this field are still allowed.

Hello @aliciagaarzo , the issue is fixed, could you have a look?

Screencast.from.2024-08-06.14-18-37.webm

Copy link

@aliciagaarzo aliciagaarzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.