Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] web_group_expand #2599

Merged
merged 16 commits into from
Sep 11, 2023
Merged

Conversation

CRogos
Copy link
Contributor

@CRogos CRogos commented Aug 29, 2023

supersedes #2490

  • cleanup commit history
  • fixed pager issue

@CRogos CRogos marked this pull request as ready for review August 29, 2023 14:08
@CRogos
Copy link
Contributor Author

CRogos commented Aug 29, 2023

@juliam3991, @dipak-shah , @MohamedOsman7 can you make a review?

@CRogos CRogos closed this Sep 5, 2023
@CRogos CRogos reopened this Sep 5, 2023
@CRogos CRogos closed this Sep 5, 2023
@CRogos CRogos reopened this Sep 5, 2023
@CRogos
Copy link
Contributor Author

CRogos commented Sep 5, 2023

@pedrobaeza do you have any idea what causes that runboat/build is not working?

@pedrobaeza
Copy link
Member

There was a problem some days ago, but seemed solved. Maybe again the same bottleneck, @sbidoul ?

@sbidoul
Copy link
Member

sbidoul commented Sep 5, 2023

Runboat seems to be running normally. I think the builds for this PR have been deleted because you closed it. Please rebase or amend a commit to trigger a new build.

Copy link

@MohamedOsman7 MohamedOsman7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CRogos
Copy link
Contributor Author

CRogos commented Sep 11, 2023

@pedrobaeza can you merge this and close #2490 ?

@pedrobaeza
Copy link
Member

/ocabot migration web_group_expand
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 11, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Sep 11, 2023
45 tasks
@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-2599-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 11, 2023
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2599-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

Please rebase and pass pre-commit

@CRogos
Copy link
Contributor Author

CRogos commented Sep 11, 2023

@pedrobaeza done, please try again.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2599-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6109c66 into OCA:16.0 Sep 11, 2023
4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 416eab9. Thanks a lot for contributing to OCA. ❤️

@CRogos CRogos deleted the 16.0-mig-web_group_expand branch September 15, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.