-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] web_group_expand #2599
Conversation
@juliam3991, @dipak-shah , @MohamedOsman7 can you make a review? |
48b3aaa
to
31df711
Compare
@pedrobaeza do you have any idea what causes that runboat/build is not working? |
There was a problem some days ago, but seemed solved. Maybe again the same bottleneck, @sbidoul ? |
Runboat seems to be running normally. I think the builds for this PR have been deleted because you closed it. Please rebase or amend a commit to trigger a new build. |
31df711
to
53ea89a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
@pedrobaeza can you merge this and close #2490 ? |
/ocabot migration web_group_expand |
Hey, thanks for contributing! Proceeding to merge this for you. |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2599-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Please rebase and pass pre-commit |
53ea89a
to
d31ec94
Compare
@pedrobaeza done, please try again. |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 416eab9. Thanks a lot for contributing to OCA. ❤️ |
supersedes #2490