Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] web_environment_ribbon: Migration to 17.0 #2667

Merged
merged 65 commits into from
Nov 15, 2023

Conversation

rven
Copy link
Contributor

@rven rven commented Nov 14, 2023

No description provided.

OpenCode and others added 30 commits November 14, 2023 10:03
ribbon_test_environment -> web_environment_ribbon
Set correct z-index on ribbon
Move position accordingly

Cf OCA#191
* [IMP] web_environment_ribbon: add color customization
The ribbon color and background-color can be modified through system
parameters:
 * ribbon.color
 * ribbon.background.color

Added Copyright in .js
Delete duplicate entries in css
By creating the ribbon div on the fly, this module doesn't depend
anymore on the webclient structure.
…(eg db_name) (OCA#621)

* [ADD] .eggs in gitignore

* [IMP] Web Environment Ribbon: add backend
This commit adds a simple bakend to facilitate inheritance

* [IMP] Web Environment Ribbon: add the databse name
This commit adds the database name under the ribbon name, in the ribbon

* [IMP] Web Environment Ribbon: prepare method for ribbon name

* [IMP] README: explain how to use db_name
* [FIX] web_environment_ribbon: Fix to show the ribbon to every non-admin user

* [FIX] web_environment_ribbon: Version number
Currently translated at 100,0% (4 of 4 strings)

Translation: web-11.0/web-11.0-web_environment_ribbon
Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_environment_ribbon/pt_BR/
[MIG] web_environment_ribbon: Migration to 12.0

[FIX] Default value for ribbon.name if not exists

[FIX] Hide ribbon when ribbon.name is false or not existing

[FIX] Remove copyright flag on __init__ files

[REM] Debugging logs

[REM] Make quotes inconsistant again and change sequence of data files in manifest
[UPD] Update web_environment_ribbon.pot

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] README.rst
Currently translated at 100.0% (4 of 4 strings)

Translation: web-12.0/web-12.0-web_environment_ribbon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_environment_ribbon/es/
Currently translated at 75.0% (3 of 4 strings)

Translation: web-12.0/web-12.0-web_environment_ribbon
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_environment_ribbon/pt/
@pedrobaeza
Copy link
Member

/ocabot migration web_environment_ribbon

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 14, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 14, 2023
26 tasks
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the feature hiding the ribbon when we mouse over it is missing. Here's like it looked like in v16

Peek 14-11-2023 15-28

@pedrobaeza
Copy link
Member

I prefer to not have such feature being honest.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, if we don't miss that feature. It works fine 😄

@rven rven force-pushed the 17.0-mig-web_environment_ribbon branch from 3ac9f58 to 926f9b9 Compare November 14, 2023 16:42
@rven rven force-pushed the 17.0-mig-web_environment_ribbon branch from 926f9b9 to 6ab8325 Compare November 14, 2023 18:51
@rven rven changed the title [MIG] web_environment_ribbon: Migration to 17.0 [17.0][MIG] web_environment_ribbon: Migration to 17.0 Nov 14, 2023
@rven
Copy link
Contributor Author

rven commented Nov 14, 2023

I prefer to not have such feature being honest.

I removed all stuff related to this hovering over banner

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat and code reviewed.

Copy link
Contributor

@ap-wtioit ap-wtioit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked code and functionality (on runbot)

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-2667-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 15a7f87 into OCA:17.0 Nov 15, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1ccfa08. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.