[8.0] web_widget_digital_signature #267

eLBati · 2015-11-26T15:13:48Z

Web Digital Signature

This module provides the functionality to store digital signature image for a record.

Usage

To use this module, you need to add widget="signature" to your binary field in your view.
You can specifify signature dimensions like the following:
<field name="signature_image" widget="signature" width="400" height="100"/>

Web Digital Signature for users

This module adds a signature field (using web_widget_digital_signature) to user form.

…e, it fits Odoo v8.0

…ature_user adding README

OCA#115 (comment)

eLBati · 2015-11-26T15:17:38Z

@JayVora-SerpentCS hi, I'm proposing this your module to be added to OCA/web. I splitted it in 2 modules, a bit improved, and added another one: web_widget_digital_signature_sale_order

@hbrunn hi, about your comment on the old PR #115 (comment), could you show an example of code the would fix it? Thanks

hbrunn · 2015-11-26T21:52:30Z

@eLBati in any case, the save function should end with

return this._super.apply(this, arguments)

Otherwise, you deactivate whatever other modules do in this function.

But as I wrote in the comment, I think you're better off not messing with the save function at all, but override get_value in instance.web.form.FieldSignature and do your click there. Even better would be a refactoring that you call a function that the click event handler also calls, then you avoid possible side effects of the clicking.

Here the relevant docstring: https://github.com/OCA/OCB/blob/8.0/addons/web/static/src/js/view_form.js#L2036

elicoidal · 2015-11-27T00:53:03Z

web_widget_digital_signature/__init__.py

@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-


Please use simple headers following OCA templates
https://github.com/OCA/maintainer-tools/blob/master/template/module/__openerp__.py#L3

elicoidal · 2015-11-27T00:57:59Z

Thanks for the contribution

eLBati · 2015-11-27T10:33:42Z

@hbrunn you can see my refactoring test at https://github.com/eLBati/web/blob/add_web_digital_sign_8_ref/web_widget_digital_signature/static/src/js/digital_sign.js
but I did not manage to make it work (I am not very confident with web widgets).

At the moment, I can avoid breaking inheritance with 3639561

eLBati · 2015-11-27T10:54:58Z

@elicoidal thanks, I made the changes

…CA/sale-workflow#252 Rename module this module in web_widget_digitized_signature

eLBati · 2015-12-29T14:12:34Z

@JayVora-SerpentCS @pedrobaeza hi, we renamed the modules and moved sale_order_widget_digitized_signature to OCA/sale-workflow#252

archetipo · 2016-01-08T11:29:25Z

👍

JayVora-SerpentCS · 2016-01-18T12:55:32Z

+1

oihane · 2016-01-18T14:20:48Z

web_widget_digitized_signature/README.rst

+
+=====================
+Web Digitized Signature
+=====================


@eLBati this == lines have to have same length as the text contained between them

oihane · 2016-01-18T14:24:18Z

Two things to fix in README files, but the rest LGTM 👍

eLBati · 2016-01-19T07:35:44Z

@oihane fixed, thanks

hbrunn · 2016-01-19T10:17:06Z

@eLBati if you remove the company logo, I think this is fit for merging: https://github.com/eLBati/web/blob/add_web_digital_sign_8/web_widget_digitized_signature/static/src/img/icon.png

hbrunn · 2016-01-19T10:20:25Z

web_widget_digitized_signature/static/src/css/jquery-ui.css

+* http://jqueryui.com
+* Includes: core.css, accordion.css, autocomplete.css, button.css, datepicker.css, dialog.css, draggable.css, menu.css, progressbar.css, resizable.css, selectable.css, selectmenu.css, slider.css, sortable.css, spinner.css, tabs.css, tooltip.css, theme.css
+* To view and modify this theme, visit http://jqueryui.com/themeroller/?ffDefault=segoe%20ui%2CArial%2Csans-serif&fwDefault=bold&fsDefault=1.1em&cornerRadius=6px&bgColorHeader=ece8da&bgTextureHeader=gloss_wave&bgImgOpacityHeader=100&borderColorHeader=d4ccb0&fcHeader=433f38&iconColorHeader=847e71&bgColorContent=f5f3e5&bgTextureContent=highlight_hard&bgImgOpacityContent=100&borderColorContent=dfd9c3&fcContent=312e25&iconColorContent=808080&bgColorDefault=459e00&bgTextureDefault=highlight_hard&bgImgOpacityDefault=15&borderColorDefault=327E04&fcDefault=ffffff&iconColorDefault=eeeeee&bgColorHover=67b021&bgTextureHover=highlight_soft&bgImgOpacityHover=25&borderColorHover=327E04&fcHover=ffffff&iconColorHover=ffffff&bgColorActive=fafaf4&bgTextureActive=highlight_hard&bgImgOpacityActive=100&borderColorActive=d4ccb0&fcActive=459e00&iconColorActive=8DC262&bgColorHighlight=fcf0ba&bgTextureHighlight=glass&bgImgOpacityHighlight=55&borderColorHighlight=e8e1b5&fcHighlight=363636&iconColorHighlight=8DC262&bgColorError=ffedad&bgTextureError=highlight_soft&bgImgOpacityError=95&borderColorError=e3a345&fcError=cd5c0a&iconColorError=cd0a0a&bgColorOverlay=2b2922&bgTextureOverlay=inset_soft&bgImgOpacityOverlay=15&opacityOverlay=90&bgColorShadow=cccccc&bgTextureShadow=highlight_hard&bgImgOpacityShadow=95&opacityShadow=20&thicknessShadow=12px&offsetTopShadow=-12px&offsetLeftShadow=-12px&cornerRadiusShadow=10px
+* Copyright 2014 jQuery Foundation and other contributors; Licensed MIT */


does this anything specific not covered by Odoo's version of jquery? https://github.com/OCA/OCB/blob/8.0/addons/web/static/lib/jquery.ui/css/smoothness/jquery-ui-1.9.1.custom.css

I don't even see this file included, can it just go away?

pedrobaeza · 2016-01-20T09:05:57Z

Please remove company logo in web_widget_digitized_signature/static/src/img/icon.png

…ature_user

eLBati · 2016-01-26T15:25:41Z

@pedrobaeza @hbrunn removed company logo and not used CSS
Thanks

hbrunn · 2016-01-27T08:00:05Z

👍

eLBati · 2016-02-25T14:55:54Z

I think this can be merged

[8.0] web_widget_digital_signature

JayVora-SerpentCS and others added 13 commits November 26, 2015 11:36

[Add] Digital Signature Module

62502bc

[ADD] Shop by brand module

819a0ea

Digital sign module updated with example

139f6d6

Add XML file to import static files instead of the __openerp__.py fil…

0b25a50

…e, it fits Odoo v8.0

Convert the business object 'Users' to Odoo 8.0 format

12c25a4

renamed to web_widget_digital_signature

48d06a8

splitting in web_widget_digital_signature and web_widget_digital_sign…

a0e4f1d

…ature_user adding README

ADD web_widget_digital_signature_sale_order

7b8186e

ADD the possibility to specify signature size

f066d6c

ADD signature size in sale order

306af65

https://github.com/OCA/web/pull/115#discussion_r28577254

e2bb37f

https://github.com/OCA/web/pull/115#discussion_r28577301

fdc4c37

OCA#115 (comment)

IMP description

c349f84

eLBati mentioned this pull request Nov 26, 2015

[MIG] migrate web_widget_digital_signature for 8.0 #115

Closed

elicoidal reviewed Nov 27, 2015
View reviewed changes

FIX calling super for save: function

3639561

FIX headers, metadata and comments

2bd1be0

archetipo added 3 commits December 22, 2015 18:50

web_widget_digital_signature_sale_order was moved in sale workflow O…

59f262c

…CA/sale-workflow#252 Rename module this module in web_widget_digitized_signature

FIX depends of web_widget_digital_signature_user

72ec9e3

[FIX] module name in digital_sign.js

05198a2

archetipo mentioned this pull request Dec 28, 2015

ADD digitized signature in mrp repair OCA/manufacture#70

Closed

oihane reviewed Jan 18, 2016
View reviewed changes

eLBati force-pushed the add_web_digital_sign_8 branch from d8a9400 to 221981e Compare January 19, 2016 07:34

hbrunn added needs fixing 8.0 labels Jan 19, 2016

hbrunn added this to the 8.0 milestone Jan 19, 2016

hbrunn reviewed Jan 19, 2016
View reviewed changes

hbrunn added the question label Jan 19, 2016

archetipo and others added 2 commits January 26, 2016 15:35

rename web_widget_digital_signature_user to web_widget_digitized_sign…

f584b8f

…ature_user

using FieldBinaryImage-signature name

411e10e

eLBati force-pushed the add_web_digital_sign_8 branch from 221981e to 411e10e Compare January 26, 2016 15:22

hbrunn removed needs fixing question labels Jan 27, 2016

hbrunn added a commit that referenced this pull request Feb 25, 2016

Merge pull request #267 from eLBati/add_web_digital_sign_8

3c67964

[8.0] web_widget_digital_signature

hbrunn merged commit 3c67964 into OCA:8.0 Feb 25, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.0] web_widget_digital_signature #267

[8.0] web_widget_digital_signature #267

eLBati commented Nov 26, 2015

eLBati commented Nov 26, 2015

hbrunn commented Nov 26, 2015

elicoidal Nov 27, 2015

elicoidal commented Nov 27, 2015

eLBati commented Nov 27, 2015

eLBati commented Nov 27, 2015

eLBati commented Dec 29, 2015

archetipo commented Jan 8, 2016

JayVora-SerpentCS commented Jan 18, 2016

oihane Jan 18, 2016

oihane commented Jan 18, 2016

eLBati commented Jan 19, 2016

hbrunn commented Jan 19, 2016

hbrunn Jan 19, 2016

hbrunn Jan 19, 2016

pedrobaeza commented Jan 20, 2016

eLBati commented Jan 26, 2016

hbrunn commented Jan 27, 2016

eLBati commented Feb 25, 2016

[8.0] web_widget_digital_signature #267

[8.0] web_widget_digital_signature #267

Conversation

eLBati commented Nov 26, 2015

Web Digital Signature

Usage

Web Digital Signature for users

eLBati commented Nov 26, 2015

hbrunn commented Nov 26, 2015

elicoidal Nov 27, 2015

Choose a reason for hiding this comment

elicoidal commented Nov 27, 2015

eLBati commented Nov 27, 2015

eLBati commented Nov 27, 2015

eLBati commented Dec 29, 2015

archetipo commented Jan 8, 2016

JayVora-SerpentCS commented Jan 18, 2016

oihane Jan 18, 2016

Choose a reason for hiding this comment

oihane commented Jan 18, 2016

eLBati commented Jan 19, 2016

hbrunn commented Jan 19, 2016

hbrunn Jan 19, 2016

Choose a reason for hiding this comment

hbrunn Jan 19, 2016

Choose a reason for hiding this comment

pedrobaeza commented Jan 20, 2016

eLBati commented Jan 26, 2016

hbrunn commented Jan 27, 2016

eLBati commented Feb 25, 2016