-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0] [MIG] web_ir_actions_act_multi #2704
base: 17.0
Are you sure you want to change the base?
[17.0] [MIG] web_ir_actions_act_multi #2704
Conversation
51a3825
to
f4bab88
Compare
/ocabot migration web_ir_actions_act_multi |
@augusto-weiss are you close to merge this pr ? |
Hi @lbisiach, sorry i lost the notification... this pr must have review |
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_ir_actions_act_multi Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_ir_actions_act_multi/
Currently translated at 100.0% (17 of 17 strings) Translation: web-16.0/web-16.0-web_ir_actions_act_multi Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_ir_actions_act_multi/es/
Currently translated at 100.0% (17 of 17 strings) Translation: web-16.0/web-16.0-web_ir_actions_act_multi Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_ir_actions_act_multi/it/
9db8993
to
de306e7
Compare
@chienandalu i update the table name, so now it's posible to uninstall the module without have a crashed db |
_inherit = "ir.actions.actions" | ||
_table = "ir_actions" | ||
_table = "ir_actions_act_multi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this change very likely needs migration scripts, so that upgrading from Odoo 16, data is correctly separated and cleaned up from the ir_actions
table and added to ir_actions_act_multi
accordingly.
de306e7
to
088ddad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of using the same table is to avoid populating too many relations for models that aren't used that much (if any)
To avoid deleting that system relation you could override the _drop_table
method and to ignore it when the model table is that one of the system.
Another option is to make the model an abstract one, although that would avoid that you could declare those actions as data (which maybe isn't done anyway...)
@chienandalu IMO make the model Abstract is a better option... i am not sure about a case where users want to declare data |
I think so, but in any case, I think a migration script should be made to avoid dropping the table when the ir.model gets unlinked. I think OU handles this with its non destructive policy but maybe in other contexts it isn't |
No description provided.