Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] web_remember_tree_column_width #2723

Merged

Conversation

cuongnmtm
Copy link
Contributor

No description provided.

frahikLV and others added 13 commits January 19, 2024 18:37
… widths

Remember the tree columns' widths across sessions, and after filtering, grouping, or reordering.
this fixes scss file not found error after installing the module
…on column

Fix an error when retrieving column sizes for lists containing one or more list_button columns.
This error occurs when a list_button column is placed between other columns in the list. This type of column is excluded from the querySelector string used to retrieve column headers, which can cause the index to shift and the column size to change when the list is displayed.
@cuongnmtm cuongnmtm mentioned this pull request Jan 19, 2024
26 tasks
@john-herholz-dt
Copy link

john-herholz-dt commented Jan 19, 2024

Hello,

Cool that you are working on it. I remember seeing a post that this was going to be a feature in Odoo Core for this version. But I am not sure if that was implemented.

Maybe check this again, before migrating?

Edit: A quick search resulted in no evidance this was implemented.

@cuongnmtm cuongnmtm force-pushed the 17.0-mig-web_remember_tree_column_width branch from 6ec4c45 to 9c46a81 Compare January 19, 2024 12:01
@cuongnmtm
Copy link
Contributor Author

john-herholz-dt

Hello, it appears that this feature has not been implemented in Odoo Core.

@cuongnmtm cuongnmtm force-pushed the 17.0-mig-web_remember_tree_column_width branch from 9c46a81 to f89a90f Compare April 9, 2024 10:35
Copy link

@CasVissers-360ERP CasVissers-360ERP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

Copy link
Member

@quoc-pn quoc-pn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional test OK

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2723-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fbc3e8e into OCA:17.0 May 7, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9552af2. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants