[17.0][MIG] web_widget_numeric_step: Migration to 17.0 #2825
+1,056
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abled by the widget
Previous this commit the widget only works with 'dots', with this commit works using odoo parse method that support other separators.
Previous this commit, the task for auto-step can enter in a infinite loop. Now only creates a new task if no other task is running.
Currently translated at 100.0% (3 of 3 strings) Translation: web-12.0/web-12.0-web_widget_numeric_step Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_numeric_step/es/
Currently translated at 100.0% (3 of 3 strings) Translation: web-13.0/web-13.0-web_widget_numeric_step Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_numeric_step/it/
Currently translated at 100.0% (3 of 3 strings) Translation: web-14.0/web-14.0-web_widget_numeric_step Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_numeric_step/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_widget_numeric_step Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_numeric_step/
Currently translated at 100.0% (3 of 3 strings) Translation: web-16.0/web-16.0-web_widget_numeric_step Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_numeric_step/es/
Currently translated at 100.0% (3 of 3 strings) Translation: web-16.0/web-16.0-web_widget_numeric_step Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_numeric_step/it/
Mobile screens benefit most from this module's enhanced usability. However, since the events used for displaying/hiding the +/- buttons depend on mouse, at the end you'll never see these buttons on mobile screens. Thus, here's a new approach: smaller screens *always* display the buttons. Besides, inputmode is now decimal, just like upstream float fields. @moduon MT-4396
Before this patch, if a field was readonly, the user could still use the +/- buttons to alter its value. Not good! @moduon MT-4396
… layout jumping otherwise Before this patch: - On a tablet, buttons wouldn't display (big screen; can't hover). - On a PC, fields would make layout jumps while hovering. @moduon MT-4472
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_widget_numeric_step Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_numeric_step/
If you're using a tablet and click on the ➕ or ➖ buttons created by this module, the result was that the numeric input related to that button got focused. On tablets, that means that the on-screen keyboard pops up. This usually triggers a layout recalculation and becomes clunky. Besides, it's useless, because if you wanted to use the keyboard, you'd have clicked on the input by yourself, and not in one of those buttons. After this change, when using a touch screen, if you click on the +/- buttons, you won't auto-focus on the input. Thus, the keyboard won't show up. @moduon MT-4472
Before this patch, when navigating inputs hitting <kbd>TAB</kbd>, you were stopped before any numeric step input. Now, you can navigate as usual and use Odoo without a 🐁. @moduon MT-4657
Default width is too narrow for these fields in list views, which makes it uncomfortable to use in desktops. @moduon MT-4472
chienandalu
suggested changes
May 16, 2024
There was a problem hiding this comment.
Thanks @achulii Looks promising, although I couldn't make it work
I have not been able to reproduce such a thing, locally I have everything working. Could you please provide more information? Thanks @chienandalu ! |
In the runbot for this PR, I set the widget in the product view for the weight field. The client doesn't recognize the widget |
The module has not been installed. |
chienandalu
approved these changes
May 16, 2024
|
Superseded by #2906 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.