[17.0][IMP] web_responsive: Redirect to home after login #2864

Patelangel1995 · 2024-06-28T06:55:53Z

Redirect to the home page after login will occur only if the user has enabled the 'Redirect to Home' configuration in their user profile settings.

OCA-git-bot · 2024-06-28T06:55:58Z

Hi @Tardo, @SplashS, @yajo,
some modules you are maintaining are being modified, check this out!

Patelangel1995 · 2024-07-02T07:21:18Z

@maintainer_username Could you please review and merge this pull request? I have completed all the required checks, but I don't have the necessary permissions to merge it myself. Thank you!

gabriel-grinspan · 2024-07-10T18:47:37Z

@yajo @Tardo @SplashS
Please review.

gabriel-grinspan · 2024-07-10T18:52:20Z

@pedrobaeza

pedrobaeza · 2024-07-10T18:53:37Z

Please squash all the commits into one and follow commit message guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

This is [IMP], not [ADD].

pedrobaeza · 2024-07-10T18:54:21Z

web_responsive/__manifest__.py

@@ -9,14 +9,14 @@
 {
    "name": "Web Responsive",
    "summary": "Responsive web client, community-supported",
-    "version": "17.0.1.0.1",
+    "version": "17.0.1.0.2",


Don't change manually the version.

pedrobaeza · 2024-07-10T18:54:30Z

web_responsive/__manifest__.py

    "category": "Website",
    "website": "https://github.com/OCA/web",
    "author": "LasLabs, Tecnativa, ITerra, Onestein, "
    "Odoo Community Association (OCA)",
    "license": "LGPL-3",
    "installable": True,
-    "depends": ["web", "mail"],
+    "depends": ["base", "web", "mail"],


No need to add this dependency.

pedrobaeza · 2024-07-10T18:54:42Z

web_responsive/models/res_users.py

@@ -24,3 +24,11 @@ class ResUsers(models.Model):
        default="milk",
        required=True,
    )
+    is_redirect_home = fields.Boolean(
+        string="Redirect to Home",
+        help="Automatically navigate to " "the home dashboard after signing in",


Suggested change

help="Automatically navigate to " "the home dashboard after signing in",

help="Automatically navigate to the home dashboard after signing in",

pedrobaeza · 2024-07-10T18:55:10Z

web_responsive/models/res_users.py

+
+    @api.onchange("action_id")
+    def _onchange_action_id(self):
+        self.is_redirect_home = self.action_id and self.is_redirect_home


I don't understand this onchange.

@pedrobaeza
Apply the change to the code as described above. This onchange method will set the value of is_redirect_home to False when the user sets the Home Action under Preferences.

OK, although this can be implemented as a computed writable field for avoiding that this works only by UI. The commit message shouldn't contain the module version, and there's still a comment unattended.

@pedrobaeza
Updated as per the suggestion.

@pedrobaeza Why do you prefer a compute field instead of a constraint?

Both are complementary. I only prefer computed writable over onchange.

Patelangel1995 · 2024-07-11T14:32:19Z

@pedrobaeza

Could you please initiate the process for the merging stage?

pedrobaeza

Working as expected. Little improvement inline.

A second review is required according OCA guidelines: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

pedrobaeza · 2024-07-11T18:03:25Z

web_responsive/models/res_users.py

+        for user in self:
+            user.is_redirect_home = False if user.action_id else user.is_redirect_home


Little code improvement:

Suggested change

for user in self:

user.is_redirect_home = False if user.action_id else user.is_redirect_home

self.filtered("action_id").is_redirect_home = False

@pedrobaeza
Updated as per the suggestion.

Patelangel1995 · 2024-07-12T04:52:11Z

@pedrobaeza
Could you kindly move forward with the next step of the approval stage?

pedrobaeza · 2024-07-12T06:11:48Z

Please check the contribution flow: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review

francesco-ooops · 2024-07-12T15:14:22Z

@Patelangel1995 if you're changing module's functional behavior, this should be added to the documentation files

Patelangel1995 · 2024-07-16T11:19:14Z

@francesco-ooops
I have made updates to the documentation.

francesco-ooops · 2024-07-16T13:14:19Z

@Patelangel1995 ok, now you can squash commits

Patelangel1995 · 2024-07-16T15:45:01Z

@francesco-ooops
Merged all commits

francesco-ooops · 2024-07-16T15:47:40Z

web_responsive/readme/DESCRIPTION.md

+- Redirect to the dashboard after logging in
+
+  ![image](../static/img/redirecthome.gif)
+


Redirect to the home page after login will occur only if the user has enabled the 'Redirect to Home' configuration in their user profile settings

@francesco-ooops
I've updated it according to the suggestion.

Redirect to the home page after login will occur only if the user has enabled the 'Redirect to Home' configuration in their user profile settings

francesco-ooops · 2024-07-17T11:09:05Z

@Patelangel1995 I see that the feature is accessible only in dev mode. Is this intended?

gabe-grinspan · 2024-07-17T11:18:02Z

@francesco-ooops
It is as intentional as Odoo's choice to make the default home action a dev mode setting. It is consistent with the rest of the system.

francesco-ooops

Functional ok!

OCA-git-bot · 2024-07-17T11:33:03Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza · 2024-07-17T11:35:33Z

/ocabot merge minor

OCA-git-bot · 2024-07-17T11:35:56Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2864-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot · 2024-07-17T11:40:48Z

Congratulations, your PR was merged at 290ec8e. Thanks a lot for contributing to OCA. ❤️

Signed-off-by pedrobaeza

pedrobaeza added this to the 17.0 milestone Jul 10, 2024

pedrobaeza reviewed Jul 10, 2024

View reviewed changes

Patelangel1995 force-pushed the 17.0 branch 2 times, most recently from a982ab8 to aa03b12 Compare July 11, 2024 11:40

pedrobaeza changed the title ~~[ADD] redirect to home after login~~ [17.0][IMP] web_responsive: Redirect to home after login Jul 11, 2024

Patelangel1995 force-pushed the 17.0 branch 3 times, most recently from 6fe5cbc to a75da85 Compare July 11, 2024 14:18

pedrobaeza approved these changes Jul 11, 2024

View reviewed changes

Patelangel1995 force-pushed the 17.0 branch from 8f9f688 to 7f76a1b Compare July 12, 2024 04:47

Patelangel1995 force-pushed the 17.0 branch from de77819 to 7f09c7f Compare July 16, 2024 15:38

francesco-ooops reviewed Jul 16, 2024

View reviewed changes

[IMP] web_responsive: Redirect to home after login

c7d59e8

Redirect to the home page after login will occur only if the user has enabled the 'Redirect to Home' configuration in their user profile settings

Patelangel1995 force-pushed the 17.0 branch from f1dbac4 to c7d59e8 Compare July 17, 2024 10:38

francesco-ooops approved these changes Jul 17, 2024

View reviewed changes

OCA-git-bot added the approved label Jul 17, 2024

OCA-git-bot added the ready to merge label Jul 17, 2024

OCA-git-bot added the bot is merging ⏳ label Jul 17, 2024

OCA-git-bot merged commit c4d889b into OCA:17.0 Jul 17, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jul 17, 2024

trisdoan pushed a commit to trisdoan/web that referenced this pull request Jul 20, 2024

Merge PR OCA#2864 into 17.0

bd886ea

Signed-off-by pedrobaeza

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][IMP] web_responsive: Redirect to home after login #2864

[17.0][IMP] web_responsive: Redirect to home after login #2864

Patelangel1995 commented Jun 28, 2024

OCA-git-bot commented Jun 28, 2024

Patelangel1995 commented Jul 2, 2024

gabriel-grinspan commented Jul 10, 2024

gabriel-grinspan commented Jul 10, 2024

pedrobaeza commented Jul 10, 2024 •

edited

Loading

pedrobaeza Jul 10, 2024

pedrobaeza Jul 10, 2024

pedrobaeza Jul 10, 2024

pedrobaeza Jul 10, 2024

Patelangel1995 Jul 11, 2024

pedrobaeza Jul 11, 2024

Patelangel1995 Jul 11, 2024

FrancoMaxime Jul 15, 2024

pedrobaeza Jul 15, 2024

Patelangel1995 commented Jul 11, 2024

pedrobaeza left a comment

pedrobaeza Jul 11, 2024

Patelangel1995 Jul 12, 2024

Patelangel1995 commented Jul 12, 2024

pedrobaeza commented Jul 12, 2024

francesco-ooops commented Jul 12, 2024

Patelangel1995 commented Jul 16, 2024

francesco-ooops commented Jul 16, 2024

Patelangel1995 commented Jul 16, 2024

francesco-ooops Jul 16, 2024

Patelangel1995 Jul 17, 2024

francesco-ooops commented Jul 17, 2024

gabe-grinspan commented Jul 17, 2024

francesco-ooops left a comment

OCA-git-bot commented Jul 17, 2024

pedrobaeza commented Jul 17, 2024

OCA-git-bot commented Jul 17, 2024

OCA-git-bot commented Jul 17, 2024

	help="Automatically navigate to " "the home dashboard after signing in",
	help="Automatically navigate to the home dashboard after signing in",

		for user in self:
		user.is_redirect_home = False if user.action_id else user.is_redirect_home

	for user in self:
	user.is_redirect_home = False if user.action_id else user.is_redirect_home
	self.filtered("action_id").is_redirect_home = False

		- Redirect to the dashboard after logging in

		![image](../static/img/redirecthome.gif)

[17.0][IMP] web_responsive: Redirect to home after login #2864

[17.0][IMP] web_responsive: Redirect to home after login #2864

Conversation

Patelangel1995 commented Jun 28, 2024

OCA-git-bot commented Jun 28, 2024

Patelangel1995 commented Jul 2, 2024

gabriel-grinspan commented Jul 10, 2024

gabriel-grinspan commented Jul 10, 2024

pedrobaeza commented Jul 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Patelangel1995 commented Jul 11, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Patelangel1995 commented Jul 12, 2024

pedrobaeza commented Jul 12, 2024

francesco-ooops commented Jul 12, 2024

Patelangel1995 commented Jul 16, 2024

francesco-ooops commented Jul 16, 2024

Patelangel1995 commented Jul 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francesco-ooops commented Jul 17, 2024

gabe-grinspan commented Jul 17, 2024

francesco-ooops left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jul 17, 2024

pedrobaeza commented Jul 17, 2024

OCA-git-bot commented Jul 17, 2024

OCA-git-bot commented Jul 17, 2024

pedrobaeza commented Jul 10, 2024 •

edited

Loading