Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG]web_field_tooltip: Migration to 17.0 #2892

Merged
merged 17 commits into from
Jul 31, 2024

Conversation

manuelregidor
Copy link
Contributor

@manuelregidor manuelregidor commented Jul 24, 2024

Refactoring. The tooltips information is shown along with the help information set in fields definitions and help information defined in views.

@HaraldPanten
@ValentinVinagre

T-6240

baimont and others added 16 commits July 24, 2024 10:11
…ip on list views. One tooltip per field and do not handle user specific tooltips
…tip from the helper, splitted resources into multiple files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_field_tooltip
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_field_tooltip/
Currently translated at 100.0% (28 of 28 strings)

Translation: web-16.0/web-16.0-web_field_tooltip
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_field_tooltip/it/
Currently translated at 82.1% (23 of 28 strings)

Translation: web-16.0/web-16.0-web_field_tooltip
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_field_tooltip/fr/
@manuelregidor
Copy link
Contributor Author

@StefanRijnhart @legalsylvain @pedrobaeza @etobella
Could you review, please? Thank you

@legalsylvain
Copy link
Contributor

Hi @manuelregidor. I don't use this module. (i don't get the interest, in fact, because it is generating double "?" icon).

image

Please avoid to ping random users. better ping original authors.
thanks !

@manuelregidor
Copy link
Contributor Author

@legalsylvain Sorry about that. The module is not generation a double "?" icon. The second icon is the one that shows the field info in v17 when the user is in debug mode.

@legalsylvain
Copy link
Contributor

legalsylvain commented Jul 24, 2024

The second icon is the one that shows the field info in v17 when the user is in debug mode.

I don't think so. step to reproduce :

  • go to runboat
  • log with demo / demo.
  • the "?" are available, even if we are not in debug mode.

image

Did I missed something ?

@manuelregidor
Copy link
Contributor Author

@legalsylvain You see that question mark because the date_order field defintion has the parameter help with the text "Creation date of draft/sent orders,\nConfirmation date of confirmed orders.". Therefore, it's completely normal to see that question mark in that specific field.

@legalsylvain
Copy link
Contributor

Yes. what is the difference between the help native field and the tooltip this module introduces ? why not use only help ?

(sorry if it's a little off topic)

@manuelregidor
Copy link
Contributor Author

@legalsylvain This module lets you easily create custom help messages for specific fields with no need of modifying any code.

@legalsylvain
Copy link
Contributor

Yes, I understand the need to create custom help via UI.
Maybe we could imagine a simpler implentation.

  • keep ir.model.fields.tooltip model
  • display in the UI the field help + tooltip concatened in the native way

-> very lighter implementation.
-> no duplicated "?" icon

what do you think ?

@manuelregidor
Copy link
Contributor Author

@legalsylvain Ok, I'll do that

@manuelregidor
Copy link
Contributor Author

@HaraldPanten Could you review, please?

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review. LGTM !

Copy link

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now, THX!

@HaraldPanten
Copy link

@etobella Could you merge this one, please? 🙏

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@manuelregidor
Copy link
Contributor Author

@Tisho99 Could yu review, please?

Copy link

@Tisho99 Tisho99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, functional and code review

@etobella
Copy link
Member

/ocabot migration web_field_tooltip

@etobella
Copy link
Member

/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jul 31, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 31, 2024
26 tasks
@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-2892-by-etobella-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f39ad2f into OCA:17.0 Jul 31, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b69af7d. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-web_field_tooltip branch August 1, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.