-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] web_widget_image_download: migration to 16.0 #2897
[16.0][MIG] web_widget_image_download: migration to 16.0 #2897
Conversation
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (1 of 1 strings) Translation: web-12.0/web-12.0-web_widget_image_download Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_image_download/zh_CN/
Currently translated at 100.0% (1 of 1 strings) Translation: web-12.0/web-12.0-web_widget_image_download Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_widget_image_download/pt/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-13.0/web-13.0-web_widget_image_download Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_image_download/
Currently translated at 100.0% (1 of 1 strings) Translation: web-13.0/web-13.0-web_widget_image_download Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_image_download/es/
Currently translated at 100.0% (1 of 1 strings) Translation: web-15.0/web-15.0-web_widget_image_download Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_widget_image_download/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-15.0/web-15.0-web_widget_image_download Translate-URL: https://translation.odoo-community.org/projects/web-15-0/web-15-0-web_widget_image_download/
90564bb
to
2e7de03
Compare
@luis-ron Could you review, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review: LGTM 👍🏻
@Tisho99 Could you review, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Code and functional review
@etobella could you assign this migration to us, and merge? THX! |
web_widget_image_download/static/src/js/web_widget_image_download.js
Outdated
Show resolved
Hide resolved
/ocabot migration web_widget_image_download |
2e7de03
to
9d55e4a
Compare
9d55e4a
to
0ff51e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/ocabot merge nobump
On my way to merge this fine PR! |
Congratulations, your PR was merged at f18b673. Thanks a lot for contributing to OCA. ❤️ |
Standard migration
The download button has been moved to the top left corner of the image as the web_widget_image_webcam module also includes a button on the bottom of the image. This way we make sure that the buttons row are not wider than the image in case this module is installed along with web_widget_image_webcam.
@HaraldPanten
@ValentinVinagre
@luis-ron
T-6451