[MIG]Migrated web tree image in v9. #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 tasks
| openerp.web_tree_image = function (instance) { | ||
| instance.web.list.Image = instance.web.list.Column.extend({ | ||
| odoo.define('web.tree_image', function (require) { | ||
| "use strict"; |
There was a problem hiding this comment.
Looks like this line needs indentation
There was a problem hiding this comment.
@StefanRijnhart I will improve the indentation.
Thanks for the review.
|
👍 |
|
👍 Nice work! |
|
Please check Travis status |
|
Thanks for the follow up. Next time, please write a comment saying that your changes are ready for review. Unfortunately, additional commits are now present. Could you please fix this branch? |
|
Sure, we will fix. |
|
The changes are ready to review now! |
|
👍 Tested on runbot |
|
Runbot 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated web tree image in v9.