Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] web_widget_dropdown_dynamic: Migration to 17.0 #2915

Merged
merged 18 commits into from
Aug 14, 2024

Conversation

CarlosRoca13
Copy link
Contributor

@CarlosRoca13
Copy link
Contributor Author

/ocabot migration web_widget_dropdown_dynamic

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Aug 13, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 13, 2024
26 tasks
@carlos-lopez-tecnativa
Copy link
Contributor

Sorry, I couldn't test it.

image

@CarlosRoca13 CarlosRoca13 force-pushed the 17.0-MIG-web_widget_dropdown_dynamic branch from 8199961 to 313e065 Compare August 13, 2024 12:56
@CarlosRoca13
Copy link
Contributor Author

Changes done

Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the demo data; it helps with testing.

One question: is this module incompatible with the web_m2x_options module?
image

@CarlosRoca13
Copy link
Contributor Author

Thanks for the notice, Carlos. The problem comes from the lack of a security control in the web_m2x_options module. I have added the fix in a new commit within this same PR.

alexey-pelykh and others added 16 commits August 14, 2024 09:17
[UPD] Update web_widget_dropdown_dynamic.pot

[UPD] Update web_widget_dropdown_dynamic_example.pot

[UPD] README.rst

[ADD] icon.png

[UPD] README.rst
Currently translated at 100.0% (1 of 1 strings)

Translation: web-13.0/web-13.0-web_widget_dropdown_dynamic
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_widget_dropdown_dynamic/es/
Currently translated at 100.0% (1 of 1 strings)

Translation: web-14.0/web-14.0-web_widget_dropdown_dynamic
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_widget_dropdown_dynamic/de/
@CarlosRoca13 CarlosRoca13 force-pushed the 17.0-MIG-web_widget_dropdown_dynamic branch from a926016 to 8f5e226 Compare August 14, 2024 07:18
@CarlosRoca13
Copy link
Contributor Author

@chienandalu changes done 😄

@CarlosRoca13 CarlosRoca13 force-pushed the 17.0-MIG-web_widget_dropdown_dynamic branch from 8f5e226 to c3acb6e Compare August 14, 2024 07:20
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

Copy link
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2915-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fba577b into OCA:17.0 Aug 14, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8d4cd1e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-MIG-web_widget_dropdown_dynamic branch August 14, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.