-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] web_notify: action button name and close #2932
Conversation
Let's try, but it seems there's a general problem with tours: /ocabot merge patch |
This PR looks fantastic, let's merge it! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge patch |
On my way to merge this fine PR! |
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
@sbidoul we are several days struggling with an error in the tests launching any tour test that avoids to merge any PR in a repository with this kind of tours.
It seems to be something on the oca-ci image or similar that prevents to launch the browser. |
Nothing has changed in the oca-ci image. Maybe it's a change in Odoo? Is there anything else in the log? To be honest I'm not familiar with the tour tests so I hope someone else can look into this. |
We have checked any possible change in Odoo upstream, and there isn't any apparently. About the image, is using any external resource, like Chrome? That one is used to run the tour tests. |
Yes, it's here: https://github.com/OCA/oca-ci/blob/f641d2587049ecd38637390f14db3bca3197a357/Dockerfile#L51-L54 It apparently installs the latest chrome version. So maybe something changed in chrome. |
Maybe related somehow odoo/odoo#178320 |
Another clue from Odoo images for runbot is that they seem to have a fixed version: https://runbot.odoo.com/runbot/dockerfile/tag/odoo:DockerMaster
|
- We can now set a button name to the notification action. - We can set an icon button as well. - After the button is clicked, the notification gets closed.
1fe3edc
to
5dea786
Compare
/ocabot merge patch |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 1316db2. Thanks a lot for contributing to OCA. ❤️ |
FW of
Includes:
cc @Tecnativa
please review @sergio-teruel @CarlosRoca13