Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] web_notify: action button name and close #2932

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

chienandalu
Copy link
Member

FW of

Includes:

  • We can now set a button name to the notification action.
  • We can set an icon button as well.
  • After the button is clicked, the notification gets closed.

cc @Tecnativa

please review @sergio-teruel @CarlosRoca13

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 21, 2024
@pedrobaeza
Copy link
Member

Let's try, but it seems there's a general problem with tours:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 21, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 23, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

@sbidoul we are several days struggling with an error in the tests launching any tour test that avoids to merge any PR in a repository with this kind of tours.

 2024-09-20 15:45:56,867 426 ERROR odoo odoo.addons.web_pivot_computed_measure.tests.test_ui_pivot: FAIL: TestUIPivot.test_ui
Traceback (most recent call last):
  File "/__w/web/web/web_pivot_computed_measure/tests/test_ui_pivot.py", line 32, in test_ui
    self.start_tour(
  File "/opt/odoo/odoo/tests/common.py", line 1857, in start_tour
    return self.browser_js(url_path=url_path, code=code, ready=ready, **kwargs)
  File "/opt/odoo/odoo/tests/common.py", line 1825, in browser_js
    self.assertTrue(self.browser._wait_ready(ready), 'The ready "%s" code was always falsy' % ready)
AssertionError: False is not true : The ready "odoo.__DEBUG__.services['web_tour.tour'].tours['web_pivot_computed_measure_tour'].ready" code was always falsy

It seems to be something on the oca-ci image or similar that prevents to launch the browser.

@sbidoul
Copy link
Member

sbidoul commented Sep 24, 2024

Nothing has changed in the oca-ci image. Maybe it's a change in Odoo? Is there anything else in the log? To be honest I'm not familiar with the tour tests so I hope someone else can look into this.

@pedrobaeza
Copy link
Member

We have checked any possible change in Odoo upstream, and there isn't any apparently. About the image, is using any external resource, like Chrome? That one is used to run the tour tests.

@sbidoul
Copy link
Member

sbidoul commented Sep 24, 2024

Yes, it's here:

https://github.com/OCA/oca-ci/blob/f641d2587049ecd38637390f14db3bca3197a357/Dockerfile#L51-L54

It apparently installs the latest chrome version. So maybe something changed in chrome.

@chienandalu
Copy link
Member Author

Maybe related somehow odoo/odoo#178320

@chienandalu
Copy link
Member Author

Another clue from Odoo images for runbot is that they seem to have a fixed version:

https://runbot.odoo.com/runbot/dockerfile/tag/odoo:DockerMaster

# Install chrome with values {"chrome_version": "126.0.6478.182-1"}
RUN curl -sSL https://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_126.0.6478.182-1_amd64.deb -o /tmp/chrome.deb \
    && apt-get update \
    && apt-get -y install --no-install-recommends /tmp/chrome.deb \
    && rm /tmp/chrome.deb

- We can now set a button name to the notification action.
- We can set an icon button as well.
- After the button is clicked, the notification gets closed.
@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1050278 into OCA:16.0 Sep 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1316db2. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-web_notify-buttons branch September 25, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants