Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] [PORT] web_send_message_popup #369

Merged
merged 1 commit into from
Jun 9, 2016

Conversation

yvaucher
Copy link
Member

@yvaucher yvaucher commented Jun 2, 2016

Change completely the module as it is now much more complicated with the javascript composer. It needs a composer to be created to call the opening of the popup.

@coveralls
Copy link

coveralls commented Jun 2, 2016

Coverage Status

Coverage remained the same at 68.116% when pulling cfea23c on yvaucher:9.0-port-web_send_message_popup into 7d240b2 on OCA:9.0.

@@ -0,0 +1,28 @@

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add copyright notice

@elicoidal
Copy link

👍 no test

@coveralls
Copy link

coveralls commented Jun 3, 2016

Coverage Status

Coverage remained the same at 68.116% when pulling 11e9c2b on yvaucher:9.0-port-web_send_message_popup into 7d240b2 on OCA:9.0.

@yvaucher yvaucher force-pushed the 9.0-port-web_send_message_popup branch from f849f6b to ac15504 Compare June 3, 2016 07:34
@yvaucher
Copy link
Member Author

yvaucher commented Jun 3, 2016

Reduced timeout, add /me as contributor, added license in js file and fixed indent in openerp.py

@coveralls
Copy link

coveralls commented Jun 3, 2016

Coverage Status

Coverage remained the same at 68.116% when pulling ac15504 on yvaucher:9.0-port-web_send_message_popup into 7d240b2 on OCA:9.0.

@coveralls
Copy link

coveralls commented Jun 3, 2016

Coverage Status

Coverage remained the same at 68.116% when pulling ac15504 on yvaucher:9.0-port-web_send_message_popup into 7d240b2 on OCA:9.0.

@guewen
Copy link
Member

guewen commented Jun 6, 2016

👍

@cyrilgdn
Copy link

cyrilgdn commented Jun 8, 2016

👍 functionally

@guewen guewen merged commit eb0d13a into OCA:9.0 Jun 9, 2016
@yvaucher yvaucher deleted the 9.0-port-web_send_message_popup branch June 9, 2016 08:48
@pedrobaeza pedrobaeza mentioned this pull request Jun 15, 2016
55 tasks
davidtranhp pushed a commit to davidtranhp/web that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants