Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Themes #37

Closed
wants to merge 2 commits into from
Closed

Color Themes #37

wants to merge 2 commits into from

Conversation

karim-omran
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.15%) when pulling 47eed1e on karim-omran:8.0 into 79112e8 on OCA:8.0.

pedrobaeza
pedrobaeza reviewed Sep 10, 2014
View reviewed changes
color_theme/__openerp__.py
'description': """
This module allows user to easily change OpenERP color theme.
=============================================================
This module allows user To define new color theme and save it for future use.\n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need \n

@dreispt dreispt mentioned this pull request Sep 18, 2014
Merged
@coveralls
Copy link

Coverage Status

Coverage decreased (-10.85%) when pulling 1bca84d on karim-omran:8.0 into 79112e8 on OCA:8.0.

@karim-omran
Copy link
Author

@pedrobaeza
fixed pep8 cols limit 80
i saw the color picker widget on OCA and i think the color picker i used is a better one and gives all color spectrum

@pedrobaeza
Copy link
Member

@ karim-omran, thanks for the changes! And don't you think it's better to update the other widget with your library and base this module on that, that duplicating color picker libs?

@legalsylvain legalsylvain added this to the 8.0 milestone Oct 14, 2014
@legalsylvain
Copy link
Contributor

@karim-omran Agree with @pedrobaeza about avoiding to duplicate library.

@pedrobaeza pedrobaeza mentioned this pull request Oct 29, 2014
Closed
@legalsylvain legalsylvain mentioned this pull request Feb 16, 2015
Merged
@legalsylvain
Copy link
Contributor

I close this PR, because 8.0/web_widget_color do the same thing.

BT-fgarbely pushed a commit to BT-fgarbely/web that referenced this pull request Apr 3, 2018
@bt-admin
Merge pull request OCA#37 from OCA/10.0
8001b18 
Syncing from upstream OCA/web (10.0)
leemannd pushed a commit to camptocamp/web that referenced this pull request May 29, 2018
Merge pull request OCA#37 from cyrilgdn/fix_scenario
b389098 
Fix scenario
vrenaville pushed a commit to camptocamp/web that referenced this pull request Jul 19, 2018
@simahawk
Merge pull request OCA#37 from guewen/rm-doc
cc4bc0f 
Remove doc, has been moved to confluence
davidtranhp added a commit to davidtranhp/web that referenced this pull request Feb 7, 2024
@davidtranhp
Merge pull request OCA#37 from Viindoo/fwd_from_14_to_15_220315_01
6dd1e1a 
Fwd from 14 to 15 220315 01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs information question
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@karim-omran @coveralls @pedrobaeza @legalsylvain @OSguard