Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] web_favicon: Migrated to 10.0 #459

Merged
merged 5 commits into from
Nov 5, 2016

Conversation

nikiwaibel
Copy link

No description provided.

@oca-clabot
Copy link

Hey @nikiwaibel, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • Odoo (no github login found)

Appreciation of efforts,
OCA CLAbot

@nikiwaibel nikiwaibel mentioned this pull request Nov 2, 2016
59 tasks
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to OCA!

Please remember to sign the CLA, and please could you take this chance to add usage instructions to the README?

Thanks!

</group>
</page>
<notebook position="inside">
<page string="Web Favicon">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add name="favicon" to <page> please

@nikiwaibel
Copy link
Author

@yajo CLA is signed and sent already.

@pedrobaeza
Copy link
Member

Can you tell me with which e-mail you sent it?

@nikiwaibel
Copy link
Author

nikiwaibel commented Nov 3, 2016

@pedrobaeza:

Date: Thu, 3 Nov 2016 02:16:37 +0100
Message-ID: CAEp2ira3iC6WE1=vDfPE5xm8bdw4Rwg8ToQHh+Aiw8eaKCRptw@mail.gmail.com
Subject: ECLA / ICLA
From: Odoo odoo@it-meisterei.eu

To: cla@odoo-community.org

@pedrobaeza
Copy link
Member

CLA checked. Please change README.rst file to point to 10.0 version instead of 9.0

@pedrobaeza
Copy link
Member

There's still at least one reference to 9.0 in the README (The "Try me on runbot" button).

@nikiwaibel
Copy link
Author

Should that be removed, or is it OK to just change the 9.0 to 10.0?

On Nov 5, 2016 11:59, "Pedro M. Baeza" notifications@github.com wrote:

There's still at least one reference to 9.0 in the README (The "Try me on
runbot" button).


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#459 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAhct7B_yP-Fl5wWeYWl-bx28qDh7MIdks5q7GGngaJpZM4Kmyb0
.

@pedrobaeza
Copy link
Member

You have to change it to 10.0.

@nikiwaibel
Copy link
Author

done. sorry for rather slow progress. i am new to all this great runbot/codecov/travis automation thingies :). when is usually the main (10.0) branch updated?

@lasley
Copy link
Contributor

lasley commented Nov 5, 2016

@nikiwaibel - The Runbot branches are built automatically upon push to the associated branch on Github. In the case of 10.0, it will be rebuilt every time a new PR is merged.

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission! Always great to see new faces in OCA 😄

Please change from openerp imports to the new v10 namespace from odoo

Also, the XML files should be upgraded from the old syntax. In order to do that, you basically just remove the <openerp> and <data> tags in favor of <odoo>.

Example

<openerp>
    <data>
        <record id="view_company_form" model="ir.ui.view">
                ...
        </record>
    </data>
</openerp>

Becomes

<odoo>
    <record id="view_company_form" model="ir.ui.view">
            ...
    </record>
</openerp>

@lasley lasley added this to the 10.0 milestone Nov 5, 2016
@nikiwaibel
Copy link
Author

@lasley done. thanks for explanations!

Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @nikiwaibel

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I hope this is the first of a lot to come! Merging.

@pedrobaeza pedrobaeza merged commit b6ab93b into OCA:10.0 Nov 5, 2016
@nikiwaibel nikiwaibel deleted the 10.0-mig-web_favicon branch November 5, 2016 18:01
misern2 pushed a commit to QubiQ/web that referenced this pull request Nov 14, 2017
mstuttgart pushed a commit to multidadosti-erp/web that referenced this pull request Mar 14, 2018
pedrobaeza pushed a commit to QubiQ/web that referenced this pull request Mar 25, 2018
fmdl pushed a commit to fmdl/web that referenced this pull request May 1, 2018
yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018
yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018
tarteo pushed a commit to tarteo/web that referenced this pull request Oct 2, 2018
pedrobaeza pushed a commit to tarteo/web that referenced this pull request Oct 24, 2018
Kev-Roche pushed a commit to akretion/web that referenced this pull request Jan 13, 2021
luisg123v pushed a commit to vauxoo-dev/web that referenced this pull request Feb 16, 2021
dc-oerp pushed a commit to dc-oerp/OCA_web that referenced this pull request Mar 14, 2024
drewes pushed a commit to agrista/odoo-web that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants