Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][IMP][web_responsive] #569

Merged
merged 8 commits into from
Mar 7, 2017
Merged

[10.0][IMP][web_responsive] #569

merged 8 commits into from
Mar 7, 2017

Conversation

tarteo
Copy link
Member

@tarteo tarteo commented Mar 3, 2017

Changes:

  • Improved position of the logo in the drawer
  • Improved position, hitbox and look (cursor: pointer) for the close drawer button
  • Improved look for the open drawer button
  • Fixed 'Try me on Runbot' button

nielsmiddeldorp
nielsmiddeldorp approved these changes Mar 3, 2017
View reviewed changes
Copy link

@nielsmiddeldorp nielsmiddeldorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes in Runbot. They are subtle changes but a welcome refinement of the module.

astirpe
astirpe approved these changes Mar 3, 2017
View reviewed changes
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Thanks @tarteo

The look for the open button looks very nice.

I've tested the position of the logo, trying images with different sizes, comparing the result with an odoo instance that doesn't have your fixes yet: in all the cases the fix you made works perfectly.

Also the position and look (with cursor "pointer") for the close button, is a great improvement for the user experience. Before this fix, the close button was a bit more difficult to click (at least for me).

lasley
lasley approved these changes Mar 7, 2017
View reviewed changes
Copy link
Contributor

@lasley lasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarteo

@lasley lasley merged commit 0fa52b4 into OCA:10.0 Mar 7, 2017
angelmoya pushed a commit to PESOL/web that referenced this pull request Oct 6, 2017
@angelmoya
[10.0][IMP][web_responsive] (OCA#569)
e164800 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018
[10.0][IMP][web_responsive] (OCA#569)
0da3773 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
yaniaular pushed a commit to vauxoo-dev/web that referenced this pull request May 14, 2018
[10.0][IMP][web_responsive] (OCA#569)
1ee3e64 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
yajo pushed a commit to Tecnativa/web that referenced this pull request Oct 5, 2018
@yajo
[10.0][IMP][web_responsive] (OCA#569)
87c5b22 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
yajo pushed a commit to Tecnativa/web that referenced this pull request Dec 10, 2018
@yajo
[10.0][IMP][web_responsive] (OCA#569)
d662159 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
tschanzt pushed a commit to camptocamp/web that referenced this pull request Jun 19, 2019
[10.0][IMP][web_responsive] (OCA#569)
fe5c966 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
Tardo pushed a commit to Tecnativa/web that referenced this pull request Sep 30, 2019
@Tardo
[10.0][IMP][web_responsive] (OCA#569)
d38158c 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
Tardo pushed a commit to Tecnativa/web that referenced this pull request Oct 13, 2019
@Tardo
[10.0][IMP][web_responsive] (OCA#569)
a7037d8 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
@tarteo tarteo deleted the 100_imp_web_responsive branch October 30, 2019 15:29
pierre-pizzetta pushed a commit to pierre-pizzetta/web that referenced this pull request Oct 17, 2020
@pierre-pizzetta
[10.0][IMP][web_responsive] (OCA#569)
f39ad3a 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
SplashS pushed a commit to SplashS/web that referenced this pull request Feb 11, 2021
[10.0][IMP][web_responsive] (OCA#569)
63b8e01 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
SplashS pushed a commit to SplashS/web that referenced this pull request Mar 17, 2021
@SplashS
[10.0][IMP][web_responsive] (OCA#569)
d24721b 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
SplashS pushed a commit to SplashS/web that referenced this pull request Oct 21, 2021
@SplashS
[10.0][IMP][web_responsive] (OCA#569)
86caefd 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
SplashS pushed a commit to SplashS/web that referenced this pull request Nov 15, 2021
@SplashS
[10.0][IMP][web_responsive] (OCA#569)
55bc3e6 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Feb 6, 2023
@bvanjeelharia
[10.0][IMP][web_responsive] (OCA#569)
5e0590d 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Feb 6, 2023
@bvanjeelharia
[10.0][IMP][web_responsive] (OCA#569)
3396f6e 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Feb 7, 2023
@bvanjeelharia
[10.0][IMP][web_responsive] (OCA#569)
9c5e174 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
bvanjeelharia pushed a commit to bvanjeelharia/web that referenced this pull request Mar 1, 2023
@bvanjeelharia
[10.0][IMP][web_responsive] (OCA#569)
ad0ff87 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
TesaLazarenko pushed a commit to TesaLazarenko/oca_web that referenced this pull request Nov 17, 2023
@TesaLazarenko
[10.0][IMP][web_responsive] (OCA#569)
6ea223c 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
davidtranhp pushed a commit to davidtranhp/web that referenced this pull request Feb 7, 2024
@bvanjeelharia
[10.0][IMP][web_responsive] (OCA#569)
b2a0466 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
davidtranhp pushed a commit to davidtranhp/web that referenced this pull request Feb 7, 2024
@TesaLazarenko
[10.0][IMP][web_responsive] (OCA#569)
7a5fa94 
* [IMP] drawer-toggle

* [IMP] Hitbox of close drawer-toggle

* [IMP] Removed outline on menu item

* [IMP] Logo positionings

* [FIX] Try me on runbot button

* [REM] Reversed outline change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@nielsmiddeldorp nielsmiddeldorp nielsmiddeldorp approved these changes

@astirpe astirpe astirpe approved these changes

@lasley lasley lasley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tarteo @lasley @astirpe @nielsmiddeldorp @rousseldenis