Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[11.0][MIG] web_no_bubble: Migration to 11.0 #765

Merged
merged 2 commits into from
Oct 24, 2017
Merged

[11.0][MIG] web_no_bubble: Migration to 11.0 #765

merged 2 commits into from
Oct 24, 2017

Conversation

oihane
Copy link
Contributor

@oihane oihane commented Oct 19, 2017

No description provided.

@pedrobaeza
Copy link
Member 

web_no_bubble/__manifest__.py:5: [C8101(manifest-required-author), ] Missing author required "Odoo Community Association (OCA)" in manifest file

@pedrobaeza pedrobaeza mentioned this pull request Oct 19, 2017
Closed
68 tasks
elicoidal
elicoidal approved these changes Oct 20, 2017
View reviewed changes
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no runbot to test but LGTM

yajo
yajo requested changes Oct 20, 2017
View reviewed changes
web_no_bubble/__manifest__.py Outdated
'maintainer': (
'Savoir-faire Linux,'
'Odoo Community Association (OCA)'
),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not used

web_no_bubble/__manifest__.py Outdated
'Savoir-faire Linux,'
'Odoo Community Association (OCA)'
),
'website': 'https://www.savoirfairelinux.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put repo or addon url

web_no_bubble/views/web_no_bubble.xml Outdated
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<openerp>
<data>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<odoo>

@oihane
Copy link
Contributor Author

oihane commented Oct 23, 2017

@yajo changes done
@elicoidal runbot is now working if you want to check again

@anajuaristi
Copy link

anajuaristi commented Oct 23, 2017 •
edited
Loading

WE STRONGLY NEED this module. Those bubles are really annoying.

Sorry for screaming. ;P

@elicoidal
Copy link

@oihane sorry I cant get the runbot running...

@yajo yajo merged commit 555add3 into OCA:11.0 Oct 24, 2017
@oihane oihane deleted the 11.0-mig-web_no_bubble branch October 24, 2017 08:24
@pedrobaeza pedrobaeza added this to the 11.0 milestone Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@elicoidal elicoidal elicoidal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oihane @pedrobaeza @anajuaristi @elicoidal @yajo