Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] web_environment_ribbon #796

Merged
merged 20 commits into from
Nov 14, 2017

Conversation

xavierjimenez
Copy link
Contributor

Module migration to version 11.0

Copy link
Contributor

@emagdalenaC2i emagdalenaC2i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Technical and functional review.
Only small changes

@@ -0,0 +1,74 @@
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. image:: /web_environment_ribbon/static/description/screenshot.png
:alt: Screenshot

Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete this part


.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/162/10.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,6 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete utf-8 line & delete copyright lines

@@ -0,0 +1,28 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete utf-8 line & delete copyright lines

'author': 'Francesco OpenCode Apruzzese, '
'Tecnativa, '
'Odoo Community Association (OCA)',
'website': 'https://it.linkedin.com/in/francescoapruzzese',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change website, should be https://github.com/OCA/web

@@ -0,0 +1,38 @@
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete the utf-8 line

@pedrobaeza pedrobaeza added this to the 11.0 milestone Nov 14, 2017
@pedrobaeza pedrobaeza mentioned this pull request Nov 14, 2017
68 tasks
@yajo
Copy link
Member

yajo commented Nov 14, 2017

Please can you squash all translation commits to merge?

@xavierjimenez
Copy link
Contributor Author

@yajo done, thanks for letting me know.

sylvainc and others added 14 commits November 14, 2017 17:10
Set correct z-index on ribbon
Move position accordingly

Cf OCA#191
* [IMP] web_environment_ribbon: add color customization
The ribbon color and background-color can be modified through system
parameters:
 * ribbon.color
 * ribbon.background.color

Added Copyright in .js
Delete duplicate entries in css
By creating the ribbon div on the fly, this module doesn't depend
anymore on the webclient structure.
…(eg db_name) (OCA#621)

* [ADD] .eggs in gitignore

* [IMP] Web Environment Ribbon: add backend
This commit adds a simple bakend to facilitate inheritance

* [IMP] Web Environment Ribbon: add the databse name
This commit adds the database name under the ribbon name, in the ribbon

* [IMP] Web Environment Ribbon: prepare method for ribbon name

* [IMP] README: explain how to use db_name
@pedrobaeza pedrobaeza force-pushed the 11.0-mig-web_environment_ribbon branch from 2746411 to e021f3d Compare November 14, 2017 16:12
@pedrobaeza pedrobaeza merged commit 4be2204 into OCA:11.0 Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.