-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] web_environment_ribbon #796
Conversation
ribbon_test_environment -> web_environment_ribbon
…ow top menu visibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Technical and functional review.
Only small changes
web_environment_ribbon/README.rst
Outdated
@@ -0,0 +1,74 @@ | |||
.. image:: https://img.shields.io/badge/licence-AGPL--3-blue.svg | |||
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be https://www.gnu.org/licenses/agpl as is defined in https://github.com/OCA/maintainer-tools/edit/master/template/module/README.rst ?
web_environment_ribbon/README.rst
Outdated
.. image:: /web_environment_ribbon/static/description/screenshot.png | ||
:alt: Screenshot | ||
|
||
Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can delete this part
web_environment_ribbon/README.rst
Outdated
|
||
.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas | ||
:alt: Try me on Runbot | ||
:target: https://runbot.odoo-community.org/runbot/162/10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be :target: https://runbot.odoo-community.org/runbot/162/11.0 ?
web_environment_ribbon/__init__.py
Outdated
@@ -0,0 +1,6 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete utf-8 line & delete copyright lines
@@ -0,0 +1,28 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete utf-8 line & delete copyright lines
'author': 'Francesco OpenCode Apruzzese, ' | ||
'Tecnativa, ' | ||
'Odoo Community Association (OCA)', | ||
'website': 'https://it.linkedin.com/in/francescoapruzzese', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change website, should be https://github.com/OCA/web
@@ -0,0 +1,38 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete the utf-8 line
Please can you squash all translation commits to merge? |
939a95d
to
2746411
Compare
@yajo done, thanks for letting me know. |
Set correct z-index on ribbon Move position accordingly Cf OCA#191
* [IMP] web_environment_ribbon: add color customization The ribbon color and background-color can be modified through system parameters: * ribbon.color * ribbon.background.color Added Copyright in .js Delete duplicate entries in css
By creating the ribbon div on the fly, this module doesn't depend anymore on the webclient structure.
…(eg db_name) (OCA#621) * [ADD] .eggs in gitignore * [IMP] Web Environment Ribbon: add backend This commit adds a simple bakend to facilitate inheritance * [IMP] Web Environment Ribbon: add the databse name This commit adds the database name under the ribbon name, in the ribbon * [IMP] Web Environment Ribbon: prepare method for ribbon name * [IMP] README: explain how to use db_name
2746411
to
e021f3d
Compare
Module migration to version 11.0