Hide header when print directly from browser issues 808 #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Next time, you can put the issue text directly in the PR. Please change module version number. @lasley, can you check? |
lasley
reviewed
Nov 22, 2017
| @@ -4,6 +4,11 @@ | |||
| header { | |||
| margin: 0; | |||
| padding: 0; | |||
|
|
|||
| @media print { | |||
| visibility: hidden; | |||
There was a problem hiding this comment.
Remove this one. Visibility hidden means that the element will still take the same amount of space, it simply won't show up. display: none is what you're going for, and I assume because it's later it's actually overriding this and removing the space
There was a problem hiding this comment.
hi, thanks for review.
updated.
please help to review again
pedrobaeza
approved these changes
Nov 27, 2017
|
@fanha99 - do you plan on backporting this? |
andreparames
pushed a commit
to acsone/web
that referenced
this pull request
Jan 23, 2018
yaniaular
pushed a commit
to vauxoo-dev/web
that referenced
this pull request
May 14, 2018
yaniaular
pushed a commit
to vauxoo-dev/web
that referenced
this pull request
May 14, 2018
yajo
pushed a commit
to Tecnativa/web
that referenced
this pull request
Oct 5, 2018
yajo
pushed a commit
to Tecnativa/web
that referenced
this pull request
Dec 10, 2018
tschanzt
pushed a commit
to camptocamp/web
that referenced
this pull request
Jun 19, 2019
Tardo
pushed a commit
to Tecnativa/web
that referenced
this pull request
Sep 30, 2019
Tardo
pushed a commit
to Tecnativa/web
that referenced
this pull request
Oct 13, 2019
pierre-pizzetta
pushed a commit
to pierre-pizzetta/web
that referenced
this pull request
Oct 17, 2020
SplashS
pushed a commit
to SplashS/web
that referenced
this pull request
Feb 11, 2021
SplashS
pushed a commit
to SplashS/web
that referenced
this pull request
Mar 17, 2021
SplashS
pushed a commit
to SplashS/web
that referenced
this pull request
Oct 21, 2021
SplashS
pushed a commit
to SplashS/web
that referenced
this pull request
Nov 15, 2021
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Feb 6, 2023
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Feb 6, 2023
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Feb 7, 2023
bvanjeelharia
pushed a commit
to bvanjeelharia/web
that referenced
this pull request
Mar 1, 2023
TesaLazarenko
pushed a commit
to TesaLazarenko/oca_web
that referenced
this pull request
Nov 17, 2023
davidtranhp
pushed a commit
to davidtranhp/web
that referenced
this pull request
Feb 7, 2024
davidtranhp
pushed a commit
to davidtranhp/web
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is for: #808