[11.0][MIG] web_widget_bokeh_chart #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid "Duplicate explicit target name" error using anonymous hyperlink references Ref.: https://stackoverflow.com/questions/5464627/how-to-have-same-text-in-two-links-with-restructured-text/14067756#14067756
simahawk
approved these changes
Feb 19, 2018
web_widget_bokeh_chart/README.rst
Outdated
|
|
||
| bokeh_chart = fields.Text( | ||
| string='Bokeh Chart', | ||
| compute=_compute_bokeh_chart) |
There was a problem hiding this comment.
compute='_compute_bokeh_chart'
|
@arkostyuk tests failing because of missing py dependency for |
|
Please include https://github.com/OCA/web/blob/10.0/.travis.yml#L35 in 11.0. Otherwise Travis complains. |
|
@jbeficent I'd prefer to state deps clearly into |
|
@simahawk @jbeficent done 😃 |
simahawk
reviewed
Feb 19, 2018
| @@ -0,0 +1 @@ | |||
| bokeh==0.12.7 | |||
There was a problem hiding this comment.
@arkostyuk I linked an example to make you spot the comments on top ;)
Add a line a above, like # web_widget_bokeh_chart
guewen
approved these changes
Feb 19, 2018
JordiBForgeFlow
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.