Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] web_tree_many2one_clickable #876

Merged
merged 6 commits into from Feb 26, 2018
Merged

[11.0][MIG] web_tree_many2one_clickable #876

merged 6 commits into from Feb 26, 2018

Conversation

ghost
Copy link

@ghost ghost commented Feb 22, 2018

Regarding #872, all one needs to do to obtain the desired behavior is to specify an explicit one2many widget on a one2many field, so there's no need for a large module.

* Therp BV
* Pedro M. Baeza <pedro.baeza@serviciosbaeza.com>
* Antonio Espinosa <antonio.espinosa@tecnativa.com>
* Sodexis <dev@sodexis.com>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add yourself

"category": "Hidden",
"website": "https://github.com/OCA/web",
"author": "Therp BV, "
"Tecnativa, "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c2c

web_tree_many2one_clickable/data/ir_config_parameter.xml Outdated Show resolved Hide resolved
web_tree_many2one_clickable/README.rst Outdated Show resolved Hide resolved

ListRenderer.include({
_renderBodyCell: function (record, node, colIndex, options) {
if (!node.attrs.widget && this.state.fields[node.attrs.name].type === 'many2one') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explain why

@pedrobaeza pedrobaeza added this to the 11.0 milestone Feb 23, 2018
@pedrobaeza pedrobaeza mentioned this pull request Feb 23, 2018
68 tasks
Copy link
Member

@astirpe astirpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: ok. Code review: ok.
Only minor non-blocking comments.

web_tree_many2one_clickable/README.rst Outdated Show resolved Hide resolved
web_tree_many2one_clickable/README.rst Outdated Show resolved Hide resolved
web_tree_many2one_clickable/__manifest__.py Outdated Show resolved Hide resolved
@pedrobaeza
Copy link
Member

Please squash migration commits and I'll merge.

Copy link

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and test

pedrobaeza and others added 6 commits February 26, 2018 21:06
Clickable many2one fields for tree views
========================================

This addon provides a separate widget to allow many2one fields in a tree view
open the linked resource when clicking on their name.

You can also define a system parameter to have this behaviour for all the
existing many2one fields in tree views.

Installation
============

Install it the regular way.

Configuration
=============

If you want to have all many2one fields clickable by default, you have to
define in *Configuration > Technical > Parameters > System parameters*, a new
parameter with name `web_tree_many2one_clickable.default` and with value
`true`.

Usage
=====

For the widget option, you need to add `widget="many2one_clickable"` attribute
in the XML field definition in the tree view.

For example:

`<field name="partner_id" widget="many2one_clickable" />`

will open the linked partner in a form view.

Known issues / Roadmap
======================

* You cannot deactivate clickable behaviour for an specific many2one field if
  you configure the system parameter.
* The value of the system parameter is retrieved for each many2one field
  present in the view instead of only once.
@pedrobaeza pedrobaeza merged commit dee7531 into OCA:11.0 Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants