-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][MIG] web_widget_many2many_tags_multi_selection
#892
[11.0][MIG] web_widget_many2many_tags_multi_selection
#892
Conversation
266834f
to
ab881c0
Compare
You have to preserve commit history following technical method in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0 |
ab881c0
to
c625657
Compare
@pedrobaeza Sorry about that. I followed the method & it should be better now hopefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. It's working, but few style remarks.
@@ -0,0 +1,46 @@ | |||
Allows multiple selection on many2many_tags widget |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to latest README template: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ! Hope I haven't forgotten anything.
I amended the original commit & force pushed to avoid adding new commits to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxyMoos Could you put the title in capital letters? 😉
|
||
This module adds a checkbox to this list so multiple entries can be selected at once. | ||
|
||
Installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add this section
Credits | ||
======= | ||
|
||
Akretion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this, as it should be inside contributors section
@@ -0,0 +1,20 @@ | |||
# -*- coding: utf-8 -*- | |||
############################################################################## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use short headers, as in https://github.com/OCA/maintainer-tools/blob/master/template/module/__init__.py (applicable to all files)
@@ -0,0 +1,20 @@ | |||
# -*- coding: utf-8 -*- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove coding, as no needed in Python-3 (applicable to all files).
c625657
to
dc7ffce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very good. I hope you'll make a lot more contributions!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on runbot. I tested by creating like 20 companies and selected them in Allowed Companies on the res.users form
'depends': [ | ||
'web', | ||
], | ||
'demo': [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really important to me but it is in the contributors guide line https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md , please remove empty keys
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
||
{ | ||
'name': 'Tags multiple selection', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capital letters...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested 👍
No description provided.