Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][MIG] web_widget_many2many_tags_multi_selection #892

Merged
merged 15 commits into from
Mar 26, 2018

Conversation

MaxyMoos
Copy link

No description provided.

@MaxyMoos MaxyMoos mentioned this pull request Mar 16, 2018
68 tasks
@MaxyMoos MaxyMoos force-pushed the many2many_tags_multi-selection branch 3 times, most recently from 266834f to ab881c0 Compare March 16, 2018 13:35
@pedrobaeza pedrobaeza added this to the 11.0 milestone Mar 16, 2018
@pedrobaeza
Copy link
Member

You have to preserve commit history following technical method in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0

@MaxyMoos MaxyMoos force-pushed the many2many_tags_multi-selection branch from ab881c0 to c625657 Compare March 19, 2018 10:43
@MaxyMoos
Copy link
Author

@pedrobaeza Sorry about that. I followed the method & it should be better now hopefully.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. It's working, but few style remarks.

@@ -0,0 +1,46 @@
Allows multiple selection on many2many_tags widget
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done ! Hope I haven't forgotten anything.
I amended the original commit & force pushed to avoid adding new commits to this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxyMoos Could you put the title in capital letters? 😉


This module adds a checkbox to this list so multiple entries can be selected at once.

Installation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add this section

Credits
=======

Akretion
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, as it should be inside contributors section

@@ -0,0 +1,20 @@
# -*- coding: utf-8 -*-
##############################################################################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use short headers, as in https://github.com/OCA/maintainer-tools/blob/master/template/module/__init__.py (applicable to all files)

@@ -0,0 +1,20 @@
# -*- coding: utf-8 -*-
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove coding, as no needed in Python-3 (applicable to all files).

@MaxyMoos MaxyMoos force-pushed the many2many_tags_multi-selection branch from c625657 to dc7ffce Compare March 19, 2018 12:39
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very good. I hope you'll make a lot more contributions!

Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on runbot. I tested by creating like 20 companies and selected them in Allowed Companies on the res.users form

'depends': [
'web',
],
'demo': [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really important to me but it is in the contributors guide line https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md , please remove empty keys

# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).

{
'name': 'Tags multiple selection',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capital letters...

Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested 👍

@pedrobaeza pedrobaeza merged commit 163a9ea into OCA:11.0 Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants