Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11.0 mig web_widget_image_download #945

Merged
merged 6 commits into from
Jun 6, 2018
Merged

11.0 mig web_widget_image_download #945

merged 6 commits into from
Jun 6, 2018

Conversation

ernestotejeda
Copy link
Member

@ernestotejeda ernestotejeda commented Jun 4, 2018 •
edited
Loading

simahawk
simahawk requested changes Jun 4, 2018
View reviewed changes
web_widget_image_download/__manifest__.py Outdated
"summary": "Allows to download any image from its widget",
"version": "11.0.1.0.0",
"category": "web",
"website": "https://www.tecnativa.com",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/OCA/web

web_widget_image_download/README.rst Outdated
@@ -0,0 +1,61 @@
.. image:: https://img.shields.io/badge/licence-LGPL--3-blue.svg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

png

web_widget_image_download/README.rst Outdated
:target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
:alt: License: LGPL-3

===========================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could update README according to new specs https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst

@rafaelbn
Copy link
Member

rafaelbn commented Jun 5, 2018

cc @Tecnativa

@pedrobaeza pedrobaeza force-pushed the 11.0-mig-web_widget_image_download branch from ffca5c1 to f40ba34 Compare June 5, 2018 18:24
pedrobaeza
pedrobaeza approved these changes Jun 5, 2018
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed/squash unneeded commits and add the README by fragments.

By my side this is working correctly.

@pedrobaeza pedrobaeza added this to the 11.0 milestone Jun 5, 2018
@pedrobaeza pedrobaeza mentioned this pull request Jun 5, 2018
Closed
chienandalu
chienandalu approved these changes Jun 6, 2018
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in runbot

@pedrobaeza pedrobaeza merged commit 67cf1bb into OCA:11.0 Jun 6, 2018
@pedrobaeza pedrobaeza mentioned this pull request Jun 6, 2018
Closed
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@chienandalu chienandalu chienandalu approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.
9 participants
@ernestotejeda @rafaelbn @simahawk @chienandalu @pedrobaeza @kutyel @yajo @smurf-U @oca-transbot