Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] website_cookiebot: Migration to 12.0 #790

Closed
wants to merge 2 commits into from

Conversation

ioans73
Copy link
Member

@ioans73 ioans73 commented Oct 30, 2020

Backport from #724

@rafaelbn rafaelbn requested a review from yajo November 3, 2020 13:21
@rafaelbn rafaelbn added this to the 12.0 milestone Nov 3, 2020
@rafaelbn
Copy link
Member

rafaelbn commented Nov 3, 2020

Hello @antonio-trey @rlizana could you please take a review in this one please?

Bots are 🍏

@@ -6,5 +6,10 @@
<script id="Cookiebot" src="https://consent.cookiebot.com/uc.js" t-att-data-cbid="website.cookiebot_id" data-blockingmode="auto" type="text/javascript"></script>
</t>
</xpath>
<xpath expr="//footer//div/span[@t-field='res_company.name']/.." position="inside">
<span>-
<a href="/legal/cookies-policy">Cookies Policy</a>
Copy link

@antonio-trey antonio-trey Nov 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spanish translation is missed (Política de cookies).

Copy link

@ferranmateu ferranmateu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 13, 2022
@github-actions github-actions bot closed this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants